Cairn

fail_closed hook non-zero exit not blocking

NousResearch/hermes-agent · cluster 102405

Data as of

Nothing open on GitHub. Fix merged in #131909. Check it covers your case.

The short answer

0open issues
0open PRs
6items grouped
Known?
Yes. 6 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #131909. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #131909. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and PRs concern a bug where fail_closed shell hooks that exit non-zero or crash without producing a directive do not correctly block execution. The work focuses on ensuring fail_closed behaves as expected in those edge cases.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #131909 fix(hooks): keep fail-closed gates from permitting crashed hooks [risk 0.20]

    merged to main

    files: agent/shell_hooks.py, tests/agent/test_shell_hooks.py, website/docs/user-guide/features/hooks.md

4 PRs closed without merging

From the close comments: done elsewhere 2 · superseded by another PR 1 · won't fix / by design 1

  • #102417 fix(hooks): keep fail-closed gates from permitting crashed hooks · done elsewhere → #131909
  • #108664 fix(shell_hooks): fail_closed must also block when the hook crashes silently · done elsewhere → #108664, #102417, #122576
  • #122576 fix(shell_hooks): fail_closed blocks a non-zero exit with no directive · won't fix / by design → #102405, #131909, #102417
  • #122651 fix(agent): fail closed when a fail_closed shell hook exits non-zero without a directive · superseded by another PR → #122576
Closed issues · 1
  • Closed#102405shell hooks: `fail_closed` does not block when the hook exits non-zero with empty stdout
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.33: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#131909
Closed issues
1
Attempts
4 PRs closed without merging
Fix link checked
3 Oct 2026

For your agent

The same facts, typed.

cluster/102405.json
cluster/102405.md