{"repo":"NousResearch/hermes-agent","public_id":"105629","display_label":"Windows desktop build ASAR integrity and stamping order","summary":"These issues and fixes address a Windows-specific build failure where the ASAR integrity rewrite by electron-builder conflicts with the subsequent rcedit stamping step, causing 'Unable to commit changes' errors. The work focuses on correcting the operation order so icon and identity stamping survives the ASAR rewrite.","subsystem":null,"counts":{"members":4,"open_issues":0,"open_issues_distinct":0,"open_prs":0,"closed_issues":1,"merged_prs":1,"attempt_prs":2},"landed_fix":{"status":"merged_to_main","basis":"structural","pr":115686,"merged_at":"2026-09-19T09:31:28+00:00"},"resolution":{"state":"resolved","by":"pr-115686"},"freshness":{"state":"verified","last_verified_at":"2026-09-19T09:31:28+00:00","is_stale":false},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.5},"fix_edges":[{"issue_number":105629,"pr_number":115686,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-19T09:31:28+00:00"}],"members":[{"kind":"issue","number":105629,"title":"# Desktop build fails on Windows: electron-builder \"updating asar integrity\" rewrite makes the subsequent afterPack rcedit stamp fail with \"Unable to commit changes\"","url":null,"state":"closed"},{"kind":"pr","number":106846,"title":"fix(desktop): order Windows PE stamping before ASAR integrity","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#115686","number":115686}],"category":"merged_via","implication":"superseded"},"merged":false},{"kind":"pr","number":109098,"title":"fix(desktop): resolve Windows packaging and stage-and-swap update conflicts (fixes #105629)","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#115686","number":115686}],"category":"implemented_elsewhere","implication":"superseded"},"merged":false},{"kind":"pr","number":115686,"title":"fix(desktop): Windows Hermes.exe icon/identity stamp survives the ASAR-integrity rewrite (#105629, salvage #106846)","url":null,"state":"merged","close_reason":{"category":"merged"},"merged":true,"is_fix_pr":true,"fix_tier":"verified","files_changed":["apps/desktop/package.json","apps/desktop/scripts/after-extract.mjs","apps/desktop/scripts/after-extract.test.mjs","apps/desktop/scripts/after-pack.mjs","apps/desktop/scripts/set-exe-identity.mjs","scripts/install.ps1"]}],"trust":{"default_tier":"verified","includes_suggested":false}}