Background review memory access scoping fixes

NousResearch/hermes-agent · cluster 105921

Data as of

Nothing open on GitHub. Fix merged in #106310. Check it covers your case.

The short answer

0open issues
0open PRs
5items grouped
Known?
Yes. 5 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #106310. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #106310. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and PRs concern a bug where the background review whitelist was applied per-tool rather than per-operation, allowing skill reviews to silently delete memory entries. The work focuses on scoping memory access permissions to the specific trigger that fired the background review.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #106310 fix(agent): a skills-only background review can no longer delete memory entries (#105921; salvage #105944, dup #105949)

    merged to main

    files: agent/background_review.py, agent/turn_context.py, run_agent.py, tests/agent/test_background_review_memory_scope.py, tests/agent/test_refine_snapshot_isolation.py, tests/tools/test_memory_tool.py, tests/tools/test_skill_provenance.py, tools/memory_tool.py, tools/skill_provenance.py

3 PRs closed without merging

From the close comments: duplicate 2 · done elsewhere 1

  • #105944 fix(agent): scope background review memory access to its trigger (#105921) · done elsewhere → e333113, #106310
  • #105949 fix(agent): scope background-review memory whitelist to the trigger that fired · duplicate → #105944, #105921
  • #105961 fix(review): scope background tools to trigger · duplicate → #105944, #105949
Closed issues · 1
  • Closed#105921Background review whitelist is per-tool, not per-operation: skill review can silently delete memory entries
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#106310
Closed issues
1
Attempts
3 PRs closed without merging
Fix link checked
9 Sep 2026

For your agent

The same facts, typed.