Reasoning visibility config fixes and display bugs
NousResearch/hermes-agent · cluster 107094
Data as of
Nothing open on GitHub. Fix merged in #113796. Check it covers your case.
The short answer
- Known?
- Yes. 5 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #113796. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
unresolved. That is separate from the fix event. - Still open
- Nothing open on GitHub.
Multiple fixes addressing incorrect rendering and emission of reasoning/chain-of-thought content when display.show_reasoning is disabled, plus a related bug where tool chrome visibility was incorrectly coupled to reasoning settings.
Open issues0
Open PRs0
Fixes on record
-
#113796 fix(agent): reasoning-only stop keeps chain-of-thought out of rows and no longer fakes a completion on a planning-monologue stall (closes remaining atoms of #111761)
files:
agent/agent_runtime_helpers.py,agent/turn_final_response.py,tests/agent/test_reasoning_only_stop_persistence.py,tests/agent/test_stall_guards.py,tests/agent/test_thinking_prefill_trailing_turn.py -
#121524 fix(tui): hide reasoning and tool chrome when show_reasoning is off
files:
apps/desktop/src/components/assistant-ui/thread/message-parts.tsx,apps/desktop/src/components/assistant-ui/tool/answer-only-chrome.test.tsx,apps/desktop/src/components/assistant-ui/tool/approval.tsx,apps/desktop/src/components/assistant-ui/tool/fallback-model/format.ts,apps/desktop/src/components/assistant-ui/tool/fallback.tsx,apps/desktop/src/components/assistant-ui/tool/run-summary.ts,apps/desktop/src/components/assistant-ui/tool/skill-activity.ts,tests/tui_gateway/test_show_reasoning_display_gate.py,tui_gateway/agent_callbacks.py,tui_gateway/server.py,tui_gateway/tool_progress.py -
#126479 Hiding reasoning no longer hides tool rows, and tool_progress: off no longer hides reasoning (salvage #125948)
files:
apps/desktop/src/app/session/hooks/use-hermes-config.test.ts,apps/desktop/src/app/session/hooks/use-hermes-config.ts,apps/desktop/src/components/assistant-ui/thread/message-parts.tsx,apps/desktop/src/components/assistant-ui/tool/approval.tsx,apps/desktop/src/components/assistant-ui/tool/fallback.tsx,apps/desktop/src/components/assistant-ui/tool/tool-feed-chrome.test.tsx,apps/desktop/src/store/tool-activity.test.ts,apps/desktop/src/store/tool-activity.ts,apps/desktop/src/types/hermes.ts,cli-config.yaml.example,contributors/emails/[redacted:email],tests/tui_gateway/test_show_reasoning_display_gate.py,tests/tui_gateway/test_todo_state_events.py,tui_gateway/agent_callbacks.py,tui_gateway/server.py,tui_gateway/tool_progress.py
1 PR closed without merging
From the close comments: done elsewhere 1
-
#108173 fix(tui_gateway): gate reasoning event emissions on display.show_reasoning config (#107094) · done elsewhere →
5f32e20,8f21606,03e17ba,#121524,#126479,#111761,#113796
Closed issues · 1
- Closed#107094[Bug]: Desktop app ignores display.show_reasoning: false — reasoning blocks still render
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab