{"repo":"NousResearch/hermes-agent","public_id":"10845","display_label":"ACP step callback falsey tool result handling","summary":"These issues and PRs concern a bug where falsey values (such as empty strings) returned as tool results are incorrectly overwritten with None in the ACP step callback. The proposed fix changes a truthiness check to a key-presence check to preserve such values.","subsystem":"acp","counts":{"members":3,"open_issues":0,"open_issues_distinct":0,"open_prs":0,"closed_issues":1,"merged_prs":1,"attempt_prs":1},"landed_fix":{"status":"merged_to_main","basis":"structural","pr":109109,"merged_at":"2026-09-12T15:29:49+00:00"},"resolution":{"state":"resolved","by":"pr-109109"},"freshness":{"state":"verified","last_verified_at":"2026-09-12T15:29:49+00:00","is_stale":false},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.6666666666666666},"fix_edges":[{"issue_number":10844,"pr_number":109109,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-12T15:29:49+00:00"},{"issue_number":10845,"pr_number":109109,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-12T15:29:49+00:00"}],"members":[{"kind":"issue","number":10845,"title":"ACP step callback rewrites empty-string tool results to None","url":null,"state":"closed"},{"kind":"pr","number":10868,"title":"fix(acp): preserve falsey tool results in step callback","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#109109","number":109109},{"kind":"pr","value":"#10844","number":10844}],"category":"merged_via","implication":"superseded"},"merged":false,"is_fix_pr":true,"fix_tier":"suggested","fix_detail_withheld":true},{"kind":"pr","number":109109,"title":"fix(acp): empty-string tool results and messages=[] reach ACP clients unchanged (#10845, #10844, salvage #10868)","url":null,"state":"merged","close_reason":{"category":"merged"},"merged":true,"is_fix_pr":true,"fix_tier":"verified","files_changed":["acp_adapter/events.py","acp_adapter/server.py","tests/acp/test_events.py","tests/acp/test_server.py"]}],"trust":{"default_tier":"verified","includes_suggested":false}}