# NousResearch/hermes-agent · Validate memory proposals before staging them

## Open now

- 1 issue, 2 PRs open on GitHub.
- #109215: \[Bug\]: Native memory stages already-invalid proposals, leaving repeat approval failures
- PR #109227: fix(memory): reject invalid proposals before staging
- PR #109280: fix(memory): stop repeating failed approval replays

These issues and pull requests address a bug where invalid memory proposals were being staged without prior validation, causing repeated approval failures. The fixes introduce validation checks that reject invalid proposals before they reach the staging step.

## TL;DR

- 4 member(s): 1 open issue(s), 0 closed issue(s), 2 open PR(s), 0 merged PR(s), 1 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.50`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #109215: \[Bug\]: Native memory stages already-invalid proposals, leaving repeat approval failures

## Prior & competing PRs

- **#109226: fix(memory): validate proposals before staging**. closed without merge
  - maintainer direction: category `merged_via`; implication `superseded`; refs `#109227`, `#109215`, `#109226`, `#109215`, `#109226`, `#109227`, `#109227`, `#109280`
- **#109227: fix(memory): reject invalid proposals before staging**. open
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `628badcdf0c8b861c5c1b7743168ba1e1fad0617`, `#109280`, `#109227`, `#109280`, `#109280`, `#109280`, `#109215`
  - files: `tests/tools/test_memory_tool.py`, `tools/memory_tool.py`, `tools/memory_tool_store.py`
- **#109280: fix(memory): stop repeating failed approval replays**. open
  - maintainer direction: category `uncategorized`; implication `needs_llm`; refs `628badcdf0c8b861c5c1b7743168ba1e1fad0617`, `#109227`
  - files: `hermes_cli/write_approval_commands.py`, `tests/tools/test_write_approval.py`, `tools/write_approval.py`

## Fix status

- No merged fix on record.
- Subsystem: `agent`