# NousResearch/hermes-agent · Fix ensureContrast ladder termination for invalid steps

## Open now

- Nothing open on GitHub.

These issues and PRs address a bug where the ensureContrast function fails to terminate or meet contrast requirements when given invalid or non-advancing step values. The fixes focus on validating and normalizing step inputs before the ladder loop runs.

## TL;DR

- 6 member(s): 0 open issue(s), 1 closed issue(s), 0 open PR(s), 1 merged PR(s), 4 PR(s) closed without merging.
- A fix was merged to main in PR #122076. Verify it addresses your case.
- **Recommended:** read PR #122076 (and any competing PRs below) before filing. Confirm the merged change covers your symptom.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `resolved` · deciding PR(s): `pr-122076`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.33`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Closed / duplicate issues

- #109955: \[Bug\]: shared ensureContrast fails to terminate or meet contrast for invalid step values

## Prior & competing PRs

- **#122076: fix: ensureContrast step validation, streaming reasoning_details, reply-scoped Copy/Read-aloud, axios lockfile, expected-quit forensics**. merged to main · fix tier `verified`
  - maintainer direction: category `merged`; implication `superseded`
  - files: `agent/chat_completion_helpers.py`, `agent/reasoning_summaries.py`, `apps/desktop/electron/crash-forensics.test.ts`, `apps/desktop/electron/crash-forensics.ts`, `apps/desktop/electron/local-backend-lifecycle.test.ts`, `apps/desktop/electron/local-backend-lifecycle.ts`, `apps/desktop/electron/ssh-bootstrap-coordinator.test.ts`, `apps/desktop/electron/ssh-bootstrap-coordinator.ts`, `apps/desktop/src/components/assistant-ui/thread/assistant-message.tsx`, `apps/desktop/src/components/assistant-ui/thread/response-copy-scope.test.tsx`, `apps/desktop/src/components/assistant-ui/thread/response-group.test.tsx`, `apps/desktop/src/i18n/ar.ts`, `apps/desktop/src/i18n/de.ts`, `apps/desktop/src/i18n/en.ts`, `apps/desktop/src/i18n/es.ts`, `apps/desktop/src/i18n/fr.ts`, `apps/desktop/src/i18n/ja.ts`, `apps/desktop/src/i18n/ru.ts`, `apps/desktop/src/i18n/types.ts`, `apps/desktop/src/i18n/zh-hant.ts` (+6 more)
- **#109967: fix(shared): validate contrast ladder step**. closed without merge
  - maintainer direction: category `uncategorized`; implication `needs_llm`; refs `#109955`, `#109975`
- **#109972: fix(shared): normalize invalid ensureContrast rung sizes so the ladder terminates**. closed without merge
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#109967`
- **#109975: fix(shared): normalize invalid ensureContrast step values before the ladder loop**. closed without merge
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `#122076`
- **#110800: fix(shared): ensureContrast terminates for non-advancing step values (#109955)**. closed without merge
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `#109975`

## Fix status

- Merged to main in PR #122076 (cited above). No release data is tracked. Verify downstream.
- Fix last verified (merged) `2026-09-27`.