NousResearch/hermes-agent

Plugin loader: fix failing sibling module sys.modules leaks

Cluster 112096. Data as of

Nothing open on GitHub. Fix merged in #118841 on 22 Sep 2026. Check it covers your case.

The short answer

0open issues
0open PRs
4items grouped
Known?
Yes. 4 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #118841. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #118841. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and PRs address a bug where a failed sibling module execution leaves a half-initialized entry in sys.modules, causing subsequent imports to raise ImportError instead of ModuleNotFoundError. Related work also covers broader plugin loader hardening such as version gating, isolation, and directory validation.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #118841 Plugin loader: version gate reads running code, SystemExit isolated, uv quarantine from any cwd, impostor dirs refused, range pins (#72052 #104404 #101962 #112096 #108371 #71650 #86992 #98407)

    merged to main

    files: contributors/emails/[email protected], hermes_cli/cli_init_mixin.py, hermes_cli/plugins.py, hermes_cli/plugins_discovery.py, hermes_cli/plugins_loader.py, hermes_cli/plugins_manifest.py, plugins/disk-cleanup/plugin.yaml, plugins/google_meet/plugin.yaml, plugins/memory/byterover/plugin.yaml, plugins/memory/hindsight/plugin.yaml, plugins/memory/holographic/plugin.yaml, plugins/memory/honcho/plugin.yaml, plugins/memory/openviking/plugin.yaml, plugins/observability/langfuse/plugin.yaml, plugins/plugin_loader.py, plugins/security-guidance/plugin.yaml, pyproject.toml, tests/hermes_cli/test_cli_init.py, tests/hermes_cli/test_plugin_manifest_v2.py, tests/hermes_cli/test_plugin_scan_dunder_dirs.py (+8 more)

2 PRs closed without merging

From the close comments: duplicate 1 · merged via another change 1

  • #112097 fix(plugins): clean failed sibling modules · merged via another change → 74f726c, #112096
  • #112444 fix(plugins): evict failed sibling exec from sys.modules so later imports raise ModuleNotFoundError · duplicate → #112097
Closed issues · 1
  • Closed#112096plugins/plugin_loader.py: failed sibling exec leaks a half-initialized module into sys.modules → later import raises ImportError, not ModuleNotFoundError
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.50: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#118841
Closed issues
1
Attempts
2 PRs closed without merging
Fix link checked
22 Sep 2026

For your agent

The same facts, typed.