Desktop native-title guard regex and scan scope fixes
Cluster 113688. Data as of
Nothing open on GitHub. Fix merged in #114969 on 18 Sep 2026. Check it covers your case.
The short answer
- Known?
- Yes. 3 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #114969. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #114969. That is separate from the fix event. - Still open
- Nothing open on GitHub.
A bug was identified where the no-native-title guard regex stops at the first '>' and only scans src/components, missing native title= attributes on buttons. Multiple fixes and site conversions address the guard's coverage holes and scanning root.
Open issues0
Open PRs0
Fixes on record
-
#114969 fix(desktop): no-native-title guard scans all of src/ and sees title= after handlers; 24 button sites converted (#113688, salvage #113717)
files:
apps/desktop/src/app/command-palette/pet-palette-page.tsx,apps/desktop/src/app/pet-generate/components/reference-chip.tsx,apps/desktop/src/app/pet-overlay/pet-overlay-app.tsx,apps/desktop/src/app/settings/appearance-settings.tsx,apps/desktop/src/app/settings/credential-key-ui.tsx,apps/desktop/src/app/settings/custom-endpoints-settings.tsx,apps/desktop/src/app/settings/providers-settings.tsx,apps/desktop/src/app/skills/mcp-tab.tsx,apps/desktop/src/components/assistant-ui/thread/changed-files-card.tsx,apps/desktop/src/components/assistant-ui/thread/user-edit-composer.tsx,apps/desktop/src/components/assistant-ui/thread/user-message.tsx,apps/desktop/src/components/chat/generated-image-result.tsx,apps/desktop/src/components/chat/preview-attachment.tsx,apps/desktop/src/components/chat/zoomable-image.tsx,apps/desktop/src/components/ui/__tests__/no-native-title.test.ts,apps/desktop/src/components/ui/zoomable.test.tsx,apps/desktop/src/components/ui/zoomable.tsx,apps/desktop/src/plugins/hermes-bots/avatar-picker.tsx,apps/desktop/src/plugins/hermes-bots/create-dialog.tsx,apps/desktop/src/plugins/hermes-bots/group-chat-view.tsx(+2 more)
1 PR closed without merging
From the close comments: merged via another change 1
-
#113717 fix(desktop): close the no-native-title guard holes and convert 22 sites to Tip · merged via another change →
0aa13a5,#114969,#113688,#113717
Closed issues · 1
- Closed#113688[Bug]: desktop no-native-title guard misses every native title= on buttons — regex stops at the first '>' and the scan root is src/components only
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
1.00: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Merged PRs
- #114969
- Closed issues
- 1
- Attempts
- 1 PR closed without merging
- Fix link checked
- 18 Sep 2026