{"repo":"NousResearch/hermes-agent","public_id":"113901","display_label":"API key redaction gaps for dotted and Zhipu keys","summary":"These issues and pull requests address secret redaction logic failing to mask API keys that contain dots after 'sk-' or use a prefix-less format, as seen with Zhipu API keys. The work focuses on expanding redaction patterns to cover these previously missed key shapes.","subsystem":null,"counts":{"members":4,"open_issues":0,"open_issues_distinct":0,"open_prs":0,"closed_issues":1,"merged_prs":1,"attempt_prs":2},"landed_fix":{"status":"merged_to_main","basis":"structural","pr":114839,"merged_at":"2026-09-18T16:58:13+00:00"},"resolution":{"state":"resolved","by":"pr-114839"},"freshness":{"state":"verified","last_verified_at":"2026-09-18T16:58:13+00:00","is_stale":false},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.5},"fix_edges":[{"issue_number":78128,"pr_number":114839,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-18T16:58:13+00:00"},{"issue_number":106508,"pr_number":114839,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-18T16:58:13+00:00"},{"issue_number":113901,"pr_number":114839,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-09-18T16:58:13+00:00"}],"members":[{"kind":"issue","number":113901,"title":"Secret redaction misses dot-containing and non-sk- prefixed API keys","url":null,"state":"closed"},{"kind":"pr","number":113908,"title":"fix(agent): redact dotted and Zhipu API keys","url":null,"state":"closed","close_reason":{"refs":[{"kind":"commit","value":"dd07510226a1","number":0},{"kind":"pr","value":"#114839","number":114839},{"kind":"pr","value":"#113901","number":113901},{"kind":"pr","value":"#78128","number":78128},{"kind":"pr","value":"#106508","number":106508},{"kind":"pr","value":"#113908","number":113908}],"category":"merged_via","implication":"superseded"},"merged":false},{"kind":"pr","number":113916,"title":"fix(redact): mask dotted sk- keys fully and Zhipu's prefix-less key shape","url":null,"state":"closed","close_reason":{"refs":[{"kind":"commit","value":"d41d8cd98f00b204e9800998ecf8427e","number":0},{"kind":"pr","value":"#113908","number":113908},{"kind":"pr","value":"#113901","number":113901}],"category":"superseded_by_pr","implication":"superseded"},"merged":false},{"kind":"pr","number":114839,"title":"fix(redact): dotted sk- keys and prefix-less Zhipu keys are fully masked in tool output (#113901, #78128, #106508, salvage #113908)","url":null,"state":"merged","close_reason":{"category":"merged"},"merged":true,"is_fix_pr":true,"fix_tier":"verified","files_changed":["agent/redact.py","tests/agent/test_redact.py","tests/tools/test_mcp_tool.py","tools/mcp_tool_common.py"]}],"trust":{"default_tier":"verified","includes_suggested":false}}