# NousResearch/hermes-agent · API key redaction gaps for dotted and Zhipu keys

## Open now

- Nothing open on GitHub.

These issues and pull requests address secret redaction logic failing to mask API keys that contain dots after 'sk-' or use a prefix-less format, as seen with Zhipu API keys. The work focuses on expanding redaction patterns to cover these previously missed key shapes.

## TL;DR

- 4 member(s): 0 open issue(s), 1 closed issue(s), 0 open PR(s), 1 merged PR(s), 2 PR(s) closed without merging.
- A fix was merged to main in PR #114839. Verify it addresses your case.
- **Recommended:** read PR #114839 (and any competing PRs below) before filing. Confirm the merged change covers your symptom.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `resolved` · deciding PR(s): `pr-114839`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.50`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Closed / duplicate issues

- #113901: Secret redaction misses dot-containing and non-sk- prefixed API keys

## Prior & competing PRs

- **#114839: fix(redact): dotted sk- keys and prefix-less Zhipu keys are fully masked in tool output (#113901, #78128, #106508, salvage #113908)**. merged to main · fix tier `verified`
  - maintainer direction: category `merged`
  - files: `agent/redact.py`, `tests/agent/test_redact.py`, `tests/tools/test_mcp_tool.py`, `tools/mcp_tool_common.py`
- **#113908: fix(agent): redact dotted and Zhipu API keys**. closed without merge
  - maintainer direction: category `merged_via`; implication `superseded`; refs `dd07510226a1`, `#114839`, `#113901`, `#78128`, `#106508`, `#113908`
- **#113916: fix(redact): mask dotted sk- keys fully and Zhipu's prefix-less key shape**. closed without merge
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `d41d8cd98f00b204e9800998ecf8427e`, `#113908`, `#113901`

## Fix status

- Merged to main in PR #114839 (cited above). No release data is tracked. Verify downstream.
- Fix last verified (merged) `2026-09-18`.