fsync correct directory for atomic writes through symlinks

NousResearch/hermes-agent · cluster 115030

Data as of 2026-10-22 12:15 UTC

Nothing open on GitHub. Fix merged in #116763. Check it covers your case.

open issues

open PRs

items grouped

Known?: Yes. 7 related items grouped here, 1 issue already closed.
Fix event: A fix was merged to main in PR #116763. Check it covers your case. No release data is tracked.
Tracker: The maintainers' tracker marks this resolved, deciding PR #116763. That is separate from the fix event.
Still open: Nothing open on GitHub.

Next step: read #116763, then check it covers your case.

Read #116763 Pick up a Lab task

These issues and PRs address a bug where atomic file writes involving symlinks incorrectly fsync the symlink's directory rather than the lookup target's directory. Multiple fix attempts and related discussions are grouped here.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

#116763 fix(utils): atomic writes fsync the directory that received the file behind a symlink (#115030, salvage #115042)

merged to main

files: contributors/emails/[redacted:email], tests/test_atomic_write_fsync_dir_target.py, utils.py

5 PRs closed without merging

From the close comments: done elsewhere 4 · merged via another change 1

#115042 fix(utils): fsync the resolved target's parent in atomic writes · merged via another change → f760dd2, #116763, #115030, #115042
#115043 fix(utils): fsync the resolved target directory in _atomic_write · done elsewhere → f760dd2, #116763, #115030, #115042
#115058 fix(utils): fsync the resolved target's directory, not the symlink's (#115030) · done elsewhere → f760dd2, #116763, #115030, #115042
#115086 fix(utils): fsync the resolved target directory for atomic writes · done elsewhere → f760dd2, #116763, #115030, #115042
#115286 fix(utils): fsync the resolved target's directory when writing through a symlink · done elsewhere → f760dd2, #116763, #115030, #115042

Closed issues · 1

Closed#115030atomic_write_text(fsync_dir=True) syncs the link directory instead of the resolved target directory

How this cluster was grouped

Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
Pairwise link density 0.29: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs: #116763
Closed issues: 1
Attempts: 5 PRs closed without merging
Fix link checked: 20 Sep 2026

For your agent

The same facts, typed.

cluster/115030.json
cluster/115030.md