Windows read-only temp pack file cleanup fixes
NousResearch/hermes-agent · cluster 116384
Data as of
Nothing open on GitHub. Fix merged in #116655. Check it covers your case.
The short answer
- Known?
- Yes. 5 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #116655. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #116655. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and PRs address failures to remove stale temporary git pack files on Windows, where read-only file attributes cause unlink to fail silently. Proposed fixes involve clearing the read-only bit before unlinking and improving logging for skipped files.
Open issues0
Open PRs0
Fixes on record
-
#116655 fix(update): stale git pack temps are actually removed on Windows and skipped files are logged at WARNING (#116384, salvage #116388)
files:
hermes_cli/gitlock.py,tests/hermes_cli/test_gitlock_tmp_packs.py -
#116948 fix(checkpoints): prune sweeps tmp_pack debris left by timed-out store gcs (#115410, salvage #115416)
files:
hermes_cli/gitlock.py,tests/hermes_cli/test_gitlock_tmp_packs.py,tests/tools/test_checkpoint_manager.py,tools/checkpoint_manager.py
2 PRs closed without merging
From the close comments: done elsewhere 2
Closed issues · 1
- Closed#116384clear_stale_tmp_packs() (#95928) silently removes nothing on Windows: git pack temps are read-only, unlink raises EACCES/13, and the skip is logged at debug
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab