Fix group-chat hold swallowing trigger messages
NousResearch/hermes-agent · cluster 117472
Data as of
Nothing open on GitHub. Fix merged in #117625. Check it covers your case.
The short answer
- Known?
- Yes. 5 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #117625. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #117625. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and pull requests address a bug where messages that trigger a group-chat hold are lost or swallowed, and related work to deliver held/skipped messages and add a toggle to disable hold detection per room.
Open issues0
Open PRs0
Fixes on record
-
#117625 fix(desktop): a group-chat hold no longer swallows the message that triggered it; stop detection can be turned off per room (#117472, salvage #117488)
files:
apps/desktop/src/plugins/hermes-bots/group-chat-timeline.test.tsx,apps/desktop/src/plugins/hermes-bots/group-chat-view-members.test.ts,apps/desktop/src/plugins/hermes-bots/group-chat-view-members.tsx,apps/desktop/src/plugins/hermes-bots/group-chat-view.inline-code.test.tsx,apps/desktop/src/plugins/hermes-bots/group-chat-view.render.test.tsx,apps/desktop/src/plugins/hermes-bots/group-chat-view.tsx,apps/desktop/src/plugins/hermes-bots/group-chat.ts,apps/desktop/src/plugins/hermes-bots/group-compress.test.tsx,apps/desktop/src/plugins/hermes-bots/group-hold-status.test.tsx,apps/desktop/src/plugins/hermes-bots/group-round-members.ts,apps/desktop/src/plugins/hermes-bots/group-rounds.test.ts,apps/desktop/src/plugins/hermes-bots/group-rounds.ts,apps/desktop/src/plugins/hermes-bots/group-turns.ts,apps/desktop/src/plugins/hermes-bots/i18n.ts,apps/desktop/src/plugins/hermes-bots/types.ts,website/docs/user-guide/bot-mode.md
3 PRs closed without merging
From the close comments: merged via another change 2 · superseded by another PR 1
-
#117488 fix(desktop): preserve messages skipped by group holds · merged via another change →
7756d04,#117625 -
#117533 fix(desktop): deliver entries a group hold swallowed on the turn after release · merged via another change →
7756d04,#117625 -
#117534 fix(desktop): deliver held messages upon resume and add hold detection toggle · superseded by another PR →
#117472
Closed issues · 1
- Closed#117472Bot Mode group chat: a Stop-hold swallows the message that triggered it, and hold detection cannot be disabled
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Merged PRs
- #117625
- Closed issues
- 1
- Attempts
- 3 PRs closed without merging
- Fix link checked
- 21 Sep 2026