NousResearch/hermes-agent

ACP session lifecycle and cleanup fixes

Cluster 118216. Data as of

Nothing open on GitHub. Fix merged in #122077 on 27 Sep 2026. Check it covers your case.

The short answer

0open issues
0open PRs
3items grouped
Known?
Yes. 3 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #122077. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #122077. That is separate from the fix event.
Still open
Nothing open on GitHub.

These items address a bug where ACP sessions were not being marked as ended upon client disconnect or shutdown, causing them to accumulate and become unreachable by archive or prune operations. Related fixes also touch approval batch re-gating, branch picker behavior, and plugin loader regex handling.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #122077 fix: ACP sessions end at shutdown, approval batch re-gates after failure, base-branch picker settles, regex literals in the plugin loader

    merged to main

    files: acp_adapter/entry.py, acp_adapter/session.py, agent/terminal_approval_batch.py, agent/tool_executor.py, apps/desktop/src/app/chat/sidebar/projects/base-branch-picker.test.tsx, apps/desktop/src/app/chat/sidebar/projects/base-branch-picker.tsx, apps/desktop/src/app/session/hooks/use-session-list-actions.ts, apps/desktop/src/contrib/runtime-loader.test.ts, apps/desktop/src/contrib/runtime-loader.ts, apps/desktop/src/lib/session-source.ts, tests/acp_adapter/test_session.py, tests/agent/test_terminal_approval_batch.py

1 PR closed without merging

From the close comments: superseded by another PR 1

  • #118244 fix(acp): stamp open sessions ended when the stdio client disconnects · superseded by another PR → #122077
Closed issues · 1
  • Closed#118216ACP sessions are never ended, so `sessions archive`/`prune` can never reach them and the desktop sidebar piles up
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#122077
Closed issues
1
Attempts
1 PR closed without merging
Fix link checked
27 Sep 2026

For your agent

The same facts, typed.