NousResearch/hermes-agent

Skills create: protect pre-existing directories from deletion

Cluster 119534 · skills. Data as of

2 open items. Fix merged in #120437 on 24 Sep 2026. Check it covers your case.

The short answer

0open issues
2open PRs
6items grouped
Known?
Yes. 6 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #120437. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #120437. That is separate from the fix event.
Still open
0 issues and 2 PRs.

These issues and PRs address a bug where the skill creation process would incorrectly remove a pre-existing directory when a security scan blocked the operation. The fix ensures that only directories created during the current operation are cleaned up on failure.

Open issues0

No open issues.

Open PRs2

  • PR#119562fix(skills): _create_skill no longer rmtrees a pre-existing directory when the security scan blocks
  • PR#119634fix(skills): refuse to adopt an occupied directory on create

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #120437 fix(skills): create never deletes a directory it did not make

    merged to main

    files: tests/tools/test_skill_manage_batch.py, tests/tools/test_skill_manager_tool.py, tools/skill_manager_batch.py, tools/skill_manager_tool.py

2 PRs closed without merging

From the close comments: done elsewhere 1 · superseded by another PR 1

  • #119535 fix(skills): don't rmtree a pre-existing dir when a create's scan blocks · done elsewhere → 334f40e, #120437, #119534
  • #120280 fix(skills): undo only this call's writes when a create scan blocks (#119534) · superseded by another PR → 334f40e, #120437, #119534
Closed issues · 1
  • Closed#119534fix(skills): _create_skill rmtrees a pre-existing directory when the security scan blocks
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.33: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
skills
Merged PRs
#120437
Closed issues
1
Attempts
2 PRs closed without merging
Fix link checked
24 Sep 2026

For your agent

The same facts, typed.