Windows desktop update exit 124 excessive node spawns fix
NousResearch/hermes-agent · cluster 123216
Data as of
Nothing open on GitHub. Fix merged in #130729. Check it covers your case.
The short answer
- Known?
- Yes. 5 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #130729. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #130729. That is separate from the fix event. - Still open
- Nothing open on GitHub.
A bug caused Windows desktop updates to always exit with code 124 because assert-dist-built spawned a separate node --check process for each renderer chunk (~960 spawns, twice), overwhelming the system past the idle watchdog timeout. Fixes address batching the checks into one child process and treating a completed update killed with exit 124 as terminal.
Open issues0
Open PRs0
Fixes on record
-
#130729 Desktop update no longer spends minutes syntax-checking renderer chunks one Node process at a time (salvage #127400, #125201)
files:
apps/desktop/package.json,apps/desktop/scripts/assert-dist-built.mjs,apps/desktop/scripts/check-chunks-parse.mjs,contributors/emails/[redacted:email],hermes_cli/source_build.py,nix/desktop.nix,tests-js/renderer-syntax-node.test.mjs,tests/hermes_cli/test_source_build.py -
#131001 Finished updates stay finished: no same-commit re-run on launch, Windows exit 124 after completion is success (salvage #123863, #127198)
files:
hermes_cli/post_update.py,hermes_cli/source_stamp.py,hermes_cli/venv_sync.py,scripts/desktop-update/windows.ps1,tests/hermes_cli/test_update_launch_completion.py,tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
2 PRs closed without merging
From the close comments: merged via another change 1 · superseded by another PR 1
Closed issues · 1
- Closed#123216[Bug]: Windows Desktop update always exits 124 - assert-dist-built spawns one node --check per renderer chunk (~960 spawns, twice), silent far past the 600s idle watchdog
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab