# NousResearch/hermes-agent · CRLF file patch matching bug with trailing newlines

## Open now

- 1 issue, 1 PR open on GitHub.
- #124166: \[Bug\]: patch on a CRLF file mishandles an old_string ending in a newline (no match, partial replace_all, wrong copy edited)
- PR #124168: fix(patch): match a CRLF file on its LF view so a trailing newline in old_string still matches

A bug where patch operations on CRLF files fail to correctly match old_string values that end in a newline, causing no match, partial replacements, or incorrect edits. Two fixes and one bug report address this same issue.

## TL;DR

- 3 member(s): 1 open issue(s), 0 closed issue(s), 1 open PR(s), 0 merged PR(s), 1 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.67`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #124166: \[Bug\]: patch on a CRLF file mishandles an old_string ending in a newline (no match, partial replace_all, wrong copy edited)

## Prior & competing PRs

- **#124168: fix(patch): match a CRLF file on its LF view so a trailing newline in old_string still matches**. open
  - maintainer direction: category `uncategorized`; implication `needs_llm`
  - files: `tests/tools/test_line_ending_preservation.py`, `tools/file_operations.py`, `tools/patch_parser.py`
- **#124227: fix(tools): match patch on a CRLF file's LF view**. closed without merge
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `#124168`, `#124166`

## Fix status

- No merged fix on record.
- Subsystem: `agent`