# NousResearch/hermes-agent · Classic-CLI approval prompts missing observer hook calls

## Open now

- Nothing open on GitHub.

These items address two classic-CLI approval prompts that do not fire the expected \`pre_approval_request\` and \`post_approval_response\` observer hooks. The work involves identifying the gap and applying a fix so those hooks are triggered consistently.

## TL;DR

- 3 member(s): 0 open issue(s), 1 closed issue(s), 0 open PR(s), 1 merged PR(s), 1 PR(s) closed without merging.
- A fix was merged to main in PR #133162. Verify it addresses your case.
- **Recommended:** read PR #133162 (and any competing PRs below) before filing. Confirm the merged change covers your symptom.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `resolved` · deciding PR(s): `pr-133162`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.67`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Closed / duplicate issues

- #131876: Two classic-CLI approval prompts fire no \`pre_approval_request\` / \`post_approval_response\` hooks

## Prior & competing PRs

- **#133162: Classic-CLI protected-write and MCP/vault consent prompts fire approval hooks (#131876, salvage #131928)**. merged to main · fix tier `verified`
  - maintainer direction: category `merged`
  - files: `hermes_cli/plugins.py`, `tests/tools/test_approval_plugin_hooks.py`, `tools/approval_prompt.py`, `tools/file_tools_write_guards.py`, `website/docs/user-guide/features/hooks.md`
- **#131928: fix(approval): fire observer hooks for the two hookless classic-CLI prompts**. closed without merge
  - maintainer direction: category `merged_via`; implication `superseded`; refs `#133162`

## Fix status

- Merged to main in PR #133162 (cited above). No release data is tracked. Verify downstream.
- Fix last verified (merged) `2026-10-05`.