{"repo":"NousResearch/hermes-agent","public_id":"13286","display_label":"Fix modal terminal tests to use assertions not returns","summary":"These issues and PRs address a bug where integration tests in test_modal_terminal.py returned boolean values instead of using assert statements, causing test failures to silently pass under pytest.","subsystem":"environments","counts":{"members":4,"open_issues":1,"open_issues_distinct":1,"open_prs":1,"closed_issues":0,"merged_prs":0,"attempt_prs":3},"landed_fix":null,"resolution":{"state":"unresolved","by":null},"freshness":{"state":"never_verified","last_verified_at":null,"is_stale":false},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.5},"fix_edges":[],"members":[{"kind":"issue","number":13286,"title":"Bug: tests/integration/test_modal_terminal.py returns booleans so logical failures still pass under pytest","url":null,"state":"open"},{"kind":"pr","number":13318,"title":"fix(tests): make test_modal_terminal actually assert, not return booleans","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#13325","number":13325},{"kind":"pr","value":"#13286","number":13286}],"category":"duplicate_of","implication":"duplicate"},"merged":false},{"kind":"pr","number":13325,"title":"fix(tests): assert modal terminal integration failures","url":null,"state":"open","close_reason":{"refs":[{"kind":"commit","value":"5b2c59559a00dff919701be4211db8d288deb20a","number":0}],"category":"superseded_by_pr","implication":"superseded"},"merged":false},{"kind":"pr","number":16088,"title":"test(modal): convert test_* return values to assert/skip","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#13318","number":13318}],"category":"superseded_by_pr","implication":"superseded"},"merged":false,"is_fix_pr":true,"fix_tier":"suggested","fix_detail_withheld":true}],"trust":{"default_tier":"verified","includes_suggested":false}}