# NousResearch/hermes-agent · Fix modal terminal tests to use assertions not returns

## Open now

- 1 issue, 1 PR open on GitHub.
- #13286: Bug: tests/integration/test_modal_terminal.py returns booleans so logical failures still pass under pytest
- PR #13325: fix(tests): assert modal terminal integration failures

These issues and PRs address a bug where integration tests in test_modal_terminal.py returned boolean values instead of using assert statements, causing test failures to silently pass under pytest.

## TL;DR

- 4 member(s): 1 open issue(s), 0 closed issue(s), 1 open PR(s), 0 merged PR(s), 2 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.50`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #13286: Bug: tests/integration/test_modal_terminal.py returns booleans so logical failures still pass under pytest

## Prior & competing PRs

- **#16088: test(modal): convert test_* return values to assert/skip**. closed without merge · fix tier `suggested`
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `#13318`
  - _suggested-tier fix detail withheld; re-request with `?tier=all` to include it._
- **#13318: fix(tests): make test_modal_terminal actually assert, not return booleans**. closed without merge
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#13325`, `#13286`
- **#13325: fix(tests): assert modal terminal integration failures**. open
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `5b2c59559a00dff919701be4211db8d288deb20a`
  - files: `tests/integration/test_modal_terminal.py`

## Fix status

- No merged fix on record.
- Subsystem: `environments`