Weixin iLink ret=-2 stale-session detection and retry

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #17432 fix(weixin): recognize ret=-2 errmsg='unknown error' as stale-session signal (#17228)

  merged to main

  files: gateway/platforms/weixin.py, tests/gateway/test_weixin.py

  Show the diff

  • gateway/platforms/weixin.py

    @@ -92,6 +92,18 @@
     RATE_LIMIT_ERRCODE = -2  # iLink frequency limit — backoff and retry
     MESSAGE_DEDUP_TTL_SECONDS = 300
     
    +
    +def _is_stale_session_ret(
    +    ret: "Optional[int]", errcode: "Optional[int]", errmsg: "Optional[str]",
    +) -> bool:
    +    """True when iLink returns ret=-2 / errcode=-2 with 'unknown error',
    +    which is a stale-session signal (same as errcode=-14) rather than
    +    a genuine rate limit."""
    +    if ret != RATE_LIMIT_ERRCODE and errcode != RATE_LIMIT_ERRCODE:
    +        return False
    +    return (errmsg or "").lower() == "unknown error"
    +
    +
     MEDIA_IMAGE = 1
     MEDIA_VIDEO = 2
     MEDIA_FILE = 3
    @@ -1254,7 +1266,8 @@ async def _poll_loop(self) -> None:
                     ret = response.get("ret", 0)
                     errcode = response.get("errcode", 0)
                     if ret not in (0, None) or errcode not in (0, None):
    -                    if ret == SESSION_EXPIRED_ERRCODE or errcode == SESSION_EXPIRED_ERRCODE:
    +                    if (ret == SESSION_EXPIRED_ERRCODE or errcode == SESSION_EXPIRED_ERRCODE
    +                            or _is_stale_session_ret(ret, errcode, response.get("errmsg"))):
                             logger.error("[%s] Session expired; pausing for 10 minutes", self.name)
                             await asyncio.sleep(600)
                             consecutive_failures = 0
    @@ -1519,6 +1532,7 @@ async def _send_text_chunk(
                             is_session_expired = (
                                 ret == SESSION_EXPIRED_ERRCODE
                                 or errcode == SESSION_EXPIRED_ERRCODE
    +                            or _is_stale_session_ret(ret, errcode, resp.get("errmsg"))
                             )
                             # Session expired — strip token and retry once
                             if is_session_expired and not retried_without_token and context_token:

  • tests/gateway/test_weixin.py

    @@ -758,3 +758,33 @@ def test_send_file_sets_voice_metadata_for_silk_payload(
             assert voice_item["encode_type"] == 6
             assert voice_item["sample_rate"] == 24000
             assert voice_item["bits_per_sample"] == 16
    +
    +
    +class TestIsStaleSessionRet:
    +    """Regression test for #17228: distinguish stale-session ret=-2 from rate-limit ret=-2."""
    +
    +    def test_ret_minus_2_with_unknown_error_is_stale(self):
    +        assert weixin._is_stale_session_ret(-2, None, "unknown error") is True
    +
    +    def test_errcode_minus_2_with_unknown_error_is_stale(self):
    +        assert weixin._is_stale_session_ret(None, -2, "unknown error") is True
    +
    +    def test_unknown_error_case_insensitive(self):
    +        assert weixin._is_stale_session_ret(-2, None, "Unknown Error") is True
    +
    +    def test_ret_minus_2_with_freq_limit_is_not_stale(self):
    +        # Genuine rate limit — must NOT be treated as stale session.
    +        assert weixin._is_stale_session_ret(-2, None, "freq limit") is False
    +
    +    def test_ret_minus_2_with_no_errmsg_is_not_stale(self):
    +        assert weixin._is_stale_session_ret(-2, None, None) is False
    +        assert weixin._is_stale_session_ret(-2, None, "") is False
    +
    +    def test_errcode_minus_14_is_not_matched_here(self):
    +        # -14 is handled by the separate SESSION_EXPIRED_ERRCODE path; the
    +        # helper only disambiguates -2 from a genuine rate limit.
    +        assert weixin._is_stale_session_ret(-14, None, "session expired") is False
    +
    +    def test_success_codes_are_not_stale(self):
    +        assert weixin._is_stale_session_ret(0, 0, "") is False
    +        assert weixin._is_stale_session_ret(None, None, "unknown error") is False