Patch tool required params, error recovery, verification fixes
NousResearch/hermes-agent · cluster 15524 · agent
Data as of
Nothing open on GitHub. Fix merged in #22143. Check it covers your case.
The short answer
- Known?
- Yes. 12 related items grouped here, 2 issues already closed.
- Fix event
- A fix was merged to main in PR #22143. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
partially resolved, deciding PR #22143. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and PRs address bugs where conditionally required patch tool parameters were systematically omitted, add per-mode parameter hints in schema descriptions, and improve recoverability from malformed patch calls. A per-turn file-mutation verifier footer is also introduced.
Open issues0
Open PRs0
Fixes on record
-
#22143 fix(patch-tool): advertise per-mode required params in schema descriptions
files:
tests/tools/test_file_tools.py,tools/file_tools.py -
#97295 feat(skill_manage): operations[] is the call — each op names its skill; atomic with cross-skill rollback
files:
tests/tools/test_skill_manage_batch.py,tests/tools/test_skill_manage_schema_diet.py,tools/skill_manager_tool.py -
#97650 fix(skill_manage): missing-old_string errors teach recovery instead of dead-ending into write_file clobbers (#33064, salvage #63879)
files:
tests/tools/test_skill_manager_tool.py,tools/skill_manager_tool.py -
#24498 feat(agent): per-turn file-mutation verifier footer
files:
hermes_cli/config.py,run_agent.py,tests/run_agent/test_file_mutation_verifier.py,website/docs/reference/environment-variables.md,website/docs/user-guide/configuration.md
6 PRs closed without merging
From the close comments: merged via another change 3 · done elsewhere 1 · superseded by another PR 1 · other 1
-
#15673 fix(patch-tool): advertise per-mode required params in schema descriptions · merged via another change →
#22143 -
#22149 fix(patch-tool): per-mode required-param hints + per-turn file-mutation verifier footer · merged via another change →
3adcc64,#24498,#15673 - #33625 fix(skills): support V4A skill_manage patches · other
-
#33652 fix(skill_manage): support V4A patch format in action='patch' · superseded by another PR →
#33625,#33064 -
#63876 fix(patch): make a half-formed replace call recoverable instead of a dead end · done elsewhere →
#507,#54572
Show 1 more
-
#63879 fix(skills): make skill_manage patch failures recoverable instead of a dead end · merged via another change →
dea2b02,0af77d1,b8203b9,#97650,#97295
Closed issues · 2
How this cluster was grouped
-
Link evidence (
partly structural links): some members are connected by structural evidence (shared changed files, or a closing/superseded reference); the rest are joined by an automated relevance judgement over their text. - Members outside that structural core may belong to a different underlying problem.
-
Pairwise link density
0.16: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab