Remove unnecessary crontab requirement from cronjob tool

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #1638 fix(tools): remove unnecessary crontab requirement from cronjob tool

  merged to main

  files: tests/tools/test_cronjob_tools.py, tools/cronjob_tools.py

  Show the diff

  • tests/tools/test_cronjob_tools.py

    @@ -62,22 +62,44 @@ def test_deception_blocked(self):
     
     
     class TestCronjobRequirements:
    -    def test_requires_crontab_binary_even_in_interactive_mode(self, monkeypatch):
    +    def test_requires_no_crontab_binary(self, monkeypatch):
    +        """Cron is internal (JSON-based scheduler), no system crontab needed."""
             monkeypatch.setenv("HERMES_INTERACTIVE", "1")
             monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
             monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
    -        monkeypatch.setattr("shutil.which", lambda name: None)
    -
    -        assert check_cronjob_requirements() is False
    +        # Even with no crontab in PATH, the cronjob tool should be available
    +        # because hermes uses an internal scheduler, not system crontab.
    +        assert check_cronjob_requirements() is True
     
    -    def test_accepts_interactive_mode_when_crontab_exists(self, monkeypatch):
    +    def test_accepts_interactive_mode(self, monkeypatch):
             monkeypatch.setenv("HERMES_INTERACTIVE", "1")
             monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
             monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
    -        monkeypatch.setattr("shutil.which", lambda name: "/usr/bin/crontab")
     
             assert check_cronjob_requirements() is True
     
    +    def test_accepts_gateway_session(self, monkeypatch):
    +        monkeypatch.delenv("HERMES_INTERACTIVE", raising=False)
    +        monkeypatch.setenv("HERMES_GATEWAY_SESSION", "1")
    +        monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
    +
    +        assert check_cronjob_requirements() is True
    +
    +    def test_accepts_exec_ask(self, monkeypatch):
    +        monkeypatch.delenv("HERMES_INTERACTIVE", raising=False)
    +        monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
    +        monkeypatch.setenv("HERMES_EXEC_ASK", "1")
    +
    +        assert check_cronjob_requirements() is True
    +
    +    def test_rejects_when_no_session_env(self, monkeypatch):
    +        """Without any session env vars, cronjob tool should not be available."""
    +        monkeypatch.delenv("HERMES_INTERACTIVE", raising=False)
    +        monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
    +        monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
    +
    +        assert check_cronjob_requirements() is False
    +
     
     # =========================================================================
     # schedule_cronjob

  • tools/cronjob_tools.py

    @@ -8,7 +8,6 @@
     import json
     import os
     import re
    -import shutil
     import sys
     from pathlib import Path
     from typing import Any, Dict, List, Optional
    @@ -414,13 +413,10 @@ def check_cronjob_requirements() -> bool:
         """
         Check if cronjob tools can be used.
     
    -    Requires 'crontab' executable to be present in the system PATH.
         Available in interactive CLI mode and gateway/messaging platforms.
    +    The cron system is internal (JSON file-based scheduler ticked by the gateway),
    +    so no external crontab executable is required.
         """
    -    # Ensure the system can actually install and manage cron entries.
    -    if not shutil.which("crontab"):
    -        return False
    -
         return bool(
             os.getenv("HERMES_INTERACTIVE")
             or os.getenv("HERMES_GATEWAY_SESSION")