CLI process loop freeze and input unresponsiveness

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #55964 fix(cli): prevent process_loop freeze from MCP reload join and voice flag leak (#16803)

  merged to main

  files: cli.py

  Show the diff

  • cli.py

    @@ -10107,9 +10107,11 @@ def _check_config_mcp_changes(self) -> None:
                 target=self._reload_mcp, daemon=True
             )
             _reload_thread.start()
    -        _reload_thread.join(timeout=30)
    -        if _reload_thread.is_alive():
    -            print("  ⚠️  MCP reload timed out (30s). Some servers may not have reconnected.")
    +        # Do NOT join here — process_loop calls this from its idle branch, so a
    +        # blocking join would freeze input consumption for up to 30s (and a hung
    +        # MCP server could block far longer). The reload runs purely in the
    +        # background daemon thread, which reports its own progress/completion
    +        # status via print() inside _reload_mcp().
     
         # Inline-skip tokens that bypass the destructive-slash confirmation modal.
         # A general escape hatch for non-interactive use (scripting/automation) and
    @@ -10737,8 +10739,16 @@ def _voice_start_recording(self):
             except Exception:
                 pass
     
    +        # Recorder creation can fail (no input device, PortAudio init error).
    +        # Reset the flag on failure or _voice_recording stays True forever and
    +        # every future voice start is silently skipped by the guard above.
             if self._voice_recorder is None:
    -            self._voice_recorder = create_audio_recorder()
    +            try:
    +                self._voice_recorder = create_audio_recorder()
    +            except Exception:
    +                with self._voice_lock:
    +                    self._voice_recording = False
    +                raise
     
             # Apply config-driven silence params (numeric-guarded so YAML
             # scalar corruption doesn't break recording start-up).