{"repo":"NousResearch/hermes-agent","public_id":"2134","display_label":"Fix visited-set sharing in resolve_toolset deduplication","summary":"These issues and PRs address a bug in resolve_toolset() where the visited set is copied rather than shared across branches, causing diamond dependency patterns to be processed multiple times. The proposed fix passes the visited set by reference so sibling and cross-branch includes are properly deduplicated.","subsystem":"agent","counts":{"members":5,"open_issues":0,"open_issues_distinct":0,"open_prs":0,"closed_issues":1,"merged_prs":1,"attempt_prs":3},"landed_fix":{"status":"merged_to_main","basis":"structural","pr":2311},"resolution":{"state":"resolved","by":"pr-2311"},"freshness":{"state":"stale","last_verified_at":"2026-03-21T14:11:28+00:00","is_stale":true},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.4},"fix_edges":[{"issue_number":2134,"pr_number":2311,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true}],"members":[{"kind":"issue","number":2134,"title":"fix(toolsets): resolve_toolset() uses visited.copy() preventing cross-branch deduplication","url":null,"state":"closed"},{"kind":"pr","number":2135,"title":"fix(toolsets): share visited set across sibling includes in resolve_toolset()","url":null,"state":"closed","close_reason":{"category":"implemented_elsewhere","implication":"superseded"},"merged":false,"is_fix_pr":true,"fix_tier":"suggested","fix_detail_withheld":true},{"kind":"pr","number":2252,"title":"fix(toolsets): share visited set across branches in resolve_toolset()","url":null,"state":"closed","close_reason":{"category":"uncategorized","implication":"needs_llm"},"merged":false,"is_fix_pr":true,"fix_tier":"suggested","fix_detail_withheld":true},{"kind":"pr","number":2292,"title":"fix(toolsets): pass visited set by reference to prevent diamond dependency duplication","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#2311","number":2311}],"category":"merged_via","implication":"superseded"},"merged":false},{"kind":"pr","number":2311,"title":"fix(toolsets): pass visited set by reference to prevent diamond dependency duplication","url":null,"state":"merged","close_reason":{"category":"merged","implication":"superseded"},"merged":true,"is_fix_pr":true,"fix_tier":"verified","files_changed":["toolsets.py"]}],"trust":{"default_tier":"verified","includes_suggested":false}}