Fix resource leak and double socket close in tools

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #2381 fix(tools): resource leak and double socket close in code_execution_tool

  merged to main

  files: tools/code_execution_tool.py

  Show the diff

  • tools/code_execution_tool.py

    @@ -300,16 +300,16 @@ def _rpc_server_loop(
                     # their status prints don't leak into the CLI spinner.
                     try:
                         _real_stdout, _real_stderr = sys.stdout, sys.stderr
    -                    sys.stdout = open(os.devnull, "w")
    -                    sys.stderr = open(os.devnull, "w")
    +                    devnull = open(os.devnull, "w")
                         try:
    +                        sys.stdout = devnull
    +                        sys.stderr = devnull
                             result = handle_function_call(
                                 tool_name, tool_args, task_id=task_id
                             )
                         finally:
    -                        sys.stdout.close()
    -                        sys.stderr.close()
                             sys.stdout, sys.stderr = _real_stdout, _real_stderr
    +                        devnull.close()
                     except Exception as exc:
                         logger.error("Tool call failed in sandbox: %s", exc, exc_info=True)
                         result = json.dumps({"error": str(exc)})
    @@ -574,6 +574,7 @@ def _drain_head_tail(pipe, head_chunks, tail_chunks, head_bytes, tail_bytes, tot
     
             # Wait for RPC thread to finish
             server_sock.close()  # break accept() so thread exits promptly
    +        server_sock = None  # prevent double close in finally
             rpc_thread.join(timeout=3)
     
             # Build response