Placeholder text leaking to users and cron targets

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #2442 fix(cron): silent jobs return empty response for delivery skip

  merged to main

  files: cron/scheduler.py, tests/cron/test_scheduler.py

  Show the diff

  • cron/scheduler.py

    @@ -412,9 +412,10 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
             
             result = agent.run_conversation(prompt)
             
    -        final_response = result.get("final_response", "")
    -        if not final_response:
    -            final_response = "(No response generated)"
    +        final_response = result.get("final_response", "") or ""
    +        # Use a separate variable for log display; keep final_response clean
    +        # for delivery logic (empty response = no delivery).
    +        logged_response = final_response if final_response else "(No response generated)"
             
             output = f"""# Cron Job: {job_name}
     
    @@ -428,7 +429,7 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
     
     ## Response
     
    -{final_response}
    +{logged_response}
     """
             
             logger.info("Job '%s' completed successfully", job_name)

  • tests/cron/test_scheduler.py

    @@ -234,6 +234,47 @@ def test_run_job_passes_session_db_and_cron_platform(self, tmp_path):
             assert kwargs["session_id"].startswith("cron_test-job_")
             fake_db.close.assert_called_once()
     
    +    def test_run_job_empty_response_returns_empty_not_placeholder(self, tmp_path):
    +        """Empty final_response should stay empty for delivery logic (issue #2234).
    +        
    +        The placeholder '(No response generated)' should only appear in the
    +        output log, not in the returned final_response that's used for delivery.
    +        """
    +        job = {
    +            "id": "silent-job",
    +            "name": "silent test",
    +            "prompt": "do work via tools only",
    +        }
    +        fake_db = MagicMock()
    +
    +        with patch("cron.scheduler._hermes_home", tmp_path), \
    +             patch("cron.scheduler._resolve_origin", return_value=None), \
    +             patch("dotenv.load_dotenv"), \
    +             patch("hermes_state.SessionDB", return_value=fake_db), \
    +             patch(
    +                 "hermes_cli.runtime_provider.resolve_runtime_provider",
    +                 return_value={
    +                     "api_key": "test-key",
    +                     "base_url": "https://example.invalid/v1",
    +                     "provider": "openrouter",
    +                     "api_mode": "chat_completions",
    +                 },
    +             ), \
    +             patch("run_agent.AIAgent") as mock_agent_cls:
    +            mock_agent = MagicMock()
    +            # Agent did work via tools but returned no text
    +            mock_agent.run_conversation.return_value = {"final_response": ""}
    +            mock_agent_cls.return_value = mock_agent
    +
    +            success, output, final_response, error = run_job(job)
    +
    +        assert success is True
    +        assert error is None
    +        # final_response should be empty for delivery logic to skip
    +        assert final_response == ""
    +        # But the output log should show the placeholder
    +        assert "(No response generated)" in output
    +
         def test_run_job_sets_auto_delivery_env_from_dotenv_home_channel(self, tmp_path, monkeypatch):
             job = {
                 "id": "test-job",

• #11021 fix: empty response nudge crash + placeholder leak to cron targets

  merged to main

  files: cron/scheduler.py, gateway/run.py, run_agent.py, scripts/release.py

  Show the diff

  • cron/scheduler.py

    @@ -837,6 +837,9 @@ def run_job(job: dict) -> tuple[bool, str, str, Optional[str]]:
                 )
     
             final_response = result.get("final_response", "") or ""
    +        # Strip leaked placeholder text that upstream may inject on empty completions.
    +        if final_response.strip() == "(No response generated)":
    +            final_response = ""
             # Use a separate variable for log display; keep final_response clean
             # for delivery logic (empty response = no delivery).
             logged_response = final_response if final_response else "(No response generated)"

  • gateway/run.py

    @@ -8886,7 +8886,7 @@ def _approval_notify_sync(approval_data: dict) -> None:
                 _resolved_model = getattr(_agent, "model", None) if _agent else None
     
                 if not final_response:
    -                error_msg = f"⚠️ {result['error']}" if result.get("error") else "(No response generated)"
    +                error_msg = f"⚠️ {result['error']}" if result.get("error") else ""
                     return {
                         "final_response": error_msg,
                         "messages": result.get("messages", []),

  • run_agent.py

    @@ -10945,8 +10945,9 @@ def _stop_spinner():
                                 #   tool(result) → assistant("(empty)") → user(nudge)
                                 # Without this, we'd have tool → user which most
                                 # APIs reject as an invalid sequence.
    -                            assistant_msg["content"] = "(empty)"
    -                            messages.append(assistant_msg)
    +                            _nudge_msg = self._build_assistant_message(assistant_message, finish_reason)
    +                            _nudge_msg["content"] = "(empty)"
    +                            messages.append(_nudge_msg)
                                 messages.append({
                                     "role": "user",
                                     "content": (

  • scripts/release.py

    @@ -179,6 +179,7 @@
         "[redacted:email]": "limars874",
         "[redacted:email]": "lesterli",
         "[redacted:email]": "MagicRay1217",
    +    "[redacted:email]": "GenKoKo",
         "[redacted:email]": "spniyant",
         "[redacted:email]": "olafthiele",
         "[redacted:email]": "sprmn24",