Approval prompt delivery and cancellation accuracy
Cluster 22992 · agent. Data as of
Nothing open on GitHub. Fix merged in #112554 on 16 Sep 2026. Check it covers your case.
The short answer
- Known?
- Yes. 4 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #112554. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #112554. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These items address issues where approval flows incorrectly report user denial when no prompt was actually shown, and work to correctly distinguish between cancelled approvals and explicit user denials. Related fixes also ensure approval, sudo, and secret prompts are properly rendered so tools do not silently time out.
Open issues0
Open PRs0
Fixes on record
-
#112308 fix(approval): withdrawn gateway approval prompts no longer read as a user deny (#112026, #22992, salvage #25305, #112032)
files:
tests/gateway/test_session_boundary_security_state.py,tests/tools/test_approval_cancelled_attribution.py,tests/tools/test_approval_interrupt.py,tools/approval.py,tools/approval_gateway_wait.py,tools/approval_prompt.py,tools/delegate_tool_child_run.py,tools/file_tools_write_guards.py,website/docs/developer-guide/observer-hooks.md,website/docs/user-guide/features/hooks.md -
#112554 CLI approval prompts that were never answered no longer read as a user denial (#22992)
files:
hermes_cli/observability/schemas/hermes.shared_metrics.v2.schema.json,hermes_cli/observability/shared_metrics_contract.py,tests/hermes_cli/test_relay_shared_metrics.py,tests/tools/test_approval.py,tests/tools/test_approval_cancelled_attribution.py,tools/approval.py,tools/approval_prompt.py,tools/file_tools_write_guards.py,website/docs/developer-guide/observer-hooks.md,website/docs/user-guide/features/hooks.md
1 PR closed without merging
From the close comments: merged via another change 1
-
#25305 fix(approval): distinguish cancelled approval from explicit user deny · merged via another change →
1e2cb57,#112308
Closed issues · 1
- Closed#22992Approval flow can return 'User denied' when no prompt is delivered
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab