# NousResearch/hermes-agent · Docker entrypoint chown of build trees after HERMES_UID remap ## Open now - Nothing open on GitHub. These items all concern the Docker entrypoint's handling of file ownership for directories such as gateway/ and ui-tui/ when HERMES_UID is remapped. One is a bug report and the others are fixes or salvage attempts touching the same ownership behavior; one also references a possible regression related to #35027. ## TL;DR - 4 member(s): 0 open issue(s), 1 closed issue(s), 0 open PR(s), 2 merged PR(s), 1 PR(s) closed without merging. - A fix was merged to main in PR #38655. Verify it addresses your case. - **Recommended:** read PR #38655 (and any competing PRs below) before filing. Confirm the merged change covers your symptom. ## Maintainer resolution verdict - Internal-tracker verdict over this cluster's issue members: `resolved` · deciding PR(s): `pr-38655`. This is distinct from the fix status above. Weigh it yourself. ## How this cluster was grouped - Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. - Pairwise link density `0.50`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked. ## Closed / duplicate issues - #27221: \[Bug\]: entrypoint.sh misses chown for ui-tui/ and gateway/ when HERMES_UID is remapped ## Prior & competing PRs - **#38556: fix(docker): chown build trees on UID remap independently of $HERMES_HOME (#35027 regression)**. merged to main · fix tier `verified` - maintainer direction: category `merged` - files: `docker/stage2-hook.sh`, `tests/tools/test_stage2_hook_build_tree_chown.py` - fix hunks: - `docker/stage2-hook.sh` ```diff @@ -154,20 +154,39 @@ if [ "$needs_chown" = true ]; then echo "[stage2] Warning: chown $HERMES_HOME/$sub failed (rootless container?) — continuing" fi done - # Hermes-owned trees under $INSTALL_DIR must be re-chowned when the UID - # is remapped — otherwise: - # - .venv: lazy_deps.py cannot install platform packages (discord.py, - # telegram, slack, etc.) with EACCES (#15012, #21100) - # - ui-tui: esbuild rebuilds dist/entry.js on every TUI launch (when - # the source mtime is newer than dist/ or when HERMES_TUI_FORCE_BUILD - # is set) and writes to ui-tui/dist/. Without this chown the new - # hermes UID can't write the build output (#28851). - # - node_modules: root-level dependencies (puppeteer, web tooling) - # that runtime code may walk/update. - # The set mirrors the build-time `chown -R hermes:hermes` line in the - # Dockerfile — keep them in sync if the Dockerfile chown set changes. - # These are under $INSTALL_DIR (not $HERMES_HOME), so the bind-mount - # concern doesn't apply — recursive is fine. +fi + +# --- Fix ownership of build trees under $INSTALL_DIR --- +# Hermes-owned trees under $INSTALL_DIR must be re-chowned whenever the +# runtime hermes UID no longer owns them — otherwise: +# - .venv: lazy_deps.py cannot install platform packages (discord.py, +# telegram, slack, etc.) with EACCES (#15012, #21100) +# - ui-tui: esbuild rebuilds dist/entry.js on every TUI launch (when +# the source mtime is newer than dist/ or when HERMES_TUI_FORCE_BUILD +# is set) and writes to ui-tui/dist/. Without this chown the new +# hermes UID can't write the build output (#28851). +# - node_modules: root-level dependencies (puppeteer, web tooling) +# that runtime code may walk/update. +# The set mirrors the build-time `chown -R hermes:hermes` line in the +# Dockerfile — keep them in sync if the Dockerfile chown set changes. +# These are under $INSTALL_DIR (not $HERMES_HOME), so the bind-mount +# concern doesn't apply — recursive is fine. +# +# This MUST be gated independently of the $HERMES_HOME ownership check +# above. `usermod -u hermes` re-chowns the hermes home dir +# ($HERMES_HOME == /opt/data) to the new UID as a side effect, so after a +# HERMES_UID/PUID remap `stat $HERMES_HOME` always already matches the new +# UID and `needs_chown` is false — but the build trees under /opt/hermes +# are NOT touched by usermod and remain owned by the build-time UID +# (10000). Gating them on $HERMES_HOME ownership (as #35027 did) silently +# skipped this chown on the common PUID/NAS path, regressing lazy installs +# and TUI rebuilds. Probe the build trees directly instead: chown only +# when the venv is not already owned by the runtime hermes UID. Idempotent +# and skips the expensive recursive chown on every restart once ownership +# is settled. +venv_owner=$(stat -c %u "$INSTALL_DIR/.venv" 2>/dev/null || echo "") +if [ -n "$venv_owner" ] && [ "$venv_owner" != "$actual_hermes_uid" ]; then + echo "[stage2] Fixing ownership of build trees under $INSTALL_DIR to hermes ($actual_hermes_uid)" chown -R hermes:hermes \ "$INSTALL_DIR/.venv" \ "$INSTALL_DIR/ui-tui" \ ``` - `tests/tools/test_stage2_hook_build_tree_chown.py` ```diff @@ -0,0 +1,122 @@ +"""Contract test: the s6-overlay stage2 hook re-chowns the build trees under +$INSTALL_DIR (/opt/hermes/.venv, ui-tui, node_modules) to the runtime hermes +UID whenever they are not already hermes-owned — INDEPENDENTLY of whether +$HERMES_HOME ownership already matches. + +Regression guard for the HERMES_UID/PUID remap path broken by #35027. + +`usermod -u hermes` re-chowns the hermes home dir ($HERMES_HOME == +/opt/data) to the new UID as a side effect. #35027 gated the build-tree chown +behind `stat $HERMES_HOME != hermes_uid`, so after any remap that stat is +already satisfied and the build-tree chown was silently skipped — leaving +.venv owned by the build-time UID (10000) and breaking: + - lazy_deps.py `uv pip install` of platform extras (#15012, #21100) + - the TUI esbuild rebuild into ui-tui/dist (#28851) + +The fix probes the build trees directly (stat .venv) rather than $HERMES_HOME. + +The extraction + stubbed-shell-run approach mirrors +tests/tools/test_stage2_hook_toplevel_chown.py. +""" +from __future__ import annotations + +import re +import shutil +import subprocess +import tempfile +from pathlib import Path + +import pytest + +REPO_ROOT = Path(__file__).resolve().parents[2] +STAGE2_HOOK = REPO_ROOT / "docker" / "stage2-hook.sh" + + [redacted:email](scope="module") +def stage2_text() -> str: + if not STAGE2_HOOK.exists(): + pytest.skip("docker/stage2-hook.sh not present in this checkout") + return STAGE2_HOOK.read_text() + + +def _build_tree_block(text: str) -> str: + """Extract the build-tree chown block: from the `venv_owner=` probe + through the closing `fi` of the chown.""" + m = re.search( + r"(venv_owner=\$\(stat[^\n]*\n(?:.*\n)*?fi)", + text, + ) + assert m, "stage2-hook.sh must contain the venv_owner-gated build-tree chown block" + return m.group(1) + + +def test_build_tree_chown_not_gated_on_hermes_home(stage2_text: str) -> None: + """The build-tree chown must NOT live inside the `if [ "$needs_chown" = true ]` + block keyed on $HERMES_HOME ownership — that is exactly the #35027 bug.""" + block = _build_tree_block(stage2_text) + # The block probes the venv owner, not $HERMES_HOME. + assert "venv_owner" in block + assert "$INSTALL_DIR/.venv" in block + # All three build trees are covered. + for tree in ("$INSTALL_DIR/.venv", "$INSTALL_DIR/ui-tui", "$INSTALL_DIR/node_modules"): + assert tree in block, f"build-tree chown must cover {tree}" + + +def _run_build_tree_block( + text: str, *, venv_owner: int, hermes_uid: int +) -> bool: + """Run the extracted build-tree block with `stat`, `id`, and `chown` + stubbed. Returns True iff the block attempted the recursive chown.""" + bash = shutil.which("bash") + if bash is None: + pytest.skip("bash not available") + block = _build_tree_block(text) + + with tempfile.TemporaryDirectory() as d: + dpath = Path(d) + log = dpath / "chown.log" + # Stubs: + # stat -c %u -> echo the simulated venv owner + # id -u hermes -> handled via actual_hermes_uid var below + # chown ... -> record that it fired + script = ( + "set -eu\n" + f'INSTALL_DIR="/opt/hermes"\n' + f'actual_hermes_uid={hermes_uid}\n' + f'stat() {{ echo {venv_owner}; }}\n' + f'chown() {{ echo fired >> "{log}"; }}\n' + + block + ) + script_path = dpath / "harness.sh" + script_path.write_text(script) + proc = subprocess.run([bash, str(script_path)], capture_output=True, text=True) + assert proc.returncode == 0, proc.stderr + return log.exists() and "fired" in log.read_text() + + +def test_chown_fires_when_venv_owner_differs(stage2_text: str) -> None: + """The #35027 regression scenario: after a remap $HERMES_HOME already + matches the new UID, but the venv is still owned by the build-time UID + (10000). The build-tree chown MUST still fire.""" + fired = _run_build_tree_block(stage2_text, venv_owner=10000, hermes_uid=4242) + assert fired, ( + "build-tree chown must fire when the venv is not owned by the runtime " + "hermes UID, regardless of $HERMES_HOME ownership (#35027 regression)" + ) + + +def test_chown_skipped_when_venv_already_owned(stage2_text: str) -> None: + """Idempotency: once the venv is hermes-owned, the recursive chown is + skipped on subsequent boots.""" + fired = _run_build_tree_block(stage2_text, venv_owner=4242, hermes_uid=4242) + assert not fired, ( + "build-tree chown must be skipped when the venv already matches the " + "runtime hermes UID (avoid expensive recursive chown on every restart)" + ) + + +def test_chown_skipped_for_default_uid(stage2_text: str) -> None: + """No remap: venv owned by the default build UID (10000) and hermes is + still 10000 — nothing to do.""" + fired = _run_build_tree_block(stage2_text, venv_owner=10000, hermes_uid=10000) + assert not fired ``` - **#38655: fix(docker): chown gateway install tree on UID remap (salvage #37928)**. merged to main · fix tier `verified` - maintainer direction: category `merged` - files: `Dockerfile`, `docker/stage2-hook.sh`, `tests/tools/test_dockerfile_node_modules_perms.py`, `tests/tools/test_stage2_hook_install_dir_chown.py` - **#37928: fix(docker): chown gateway after UID remap**. closed without merge - maintainer direction: category `implemented_elsewhere`; implication `superseded`; refs `#38655`, `#27221`, `#38556` ## Fix status - Merged to main in PR #38655 (cited above). No release data is tracked. Verify downstream. - Fix last verified (merged) `2026-06-04`. - Subsystem: `environments`