kanban unblock multi-word reason argparse bug

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #34411 fix(kanban): add --reason flag to unblock for symmetry with block (#30897)

  merged to main

  files: hermes_cli/kanban.py, scripts/release.py

  Show the diff

  • hermes_cli/kanban.py

    @@ -548,6 +548,11 @@ def build_parser(parent_subparsers: argparse._SubParsersAction) -> argparse.Argu
                                 help="Additional task ids to schedule with the same reason (bulk mode)")
     
         p_unblock = sub.add_parser("unblock", help="Return one or more blocked/scheduled tasks to ready")
    +    p_unblock.add_argument(
    +        "--reason",
    +        default=None,
    +        help="Optional reason/note — recorded as a comment before unblocking. Quote multi-word reasons.",
    +    )
         p_unblock.add_argument("task_ids", nargs="+")
     
         p_promote = sub.add_parser(
    @@ -1978,14 +1983,20 @@ def _cmd_unblock(args: argparse.Namespace) -> int:
         if not ids:
             print("at least one task_id is required", file=sys.stderr)
             return 1
    +    reason = getattr(args, "reason", None)
    +    if reason is not None:
    +        reason = reason.strip() or None
    +    author = _profile_author() if reason else None
         failed: list[str] = []
         with kb.connect_closing() as conn:
             for tid in ids:
    +            if reason:
    +                kb.add_comment(conn, tid, author, f"UNBLOCK: {reason}")
                 if not kb.unblock_task(conn, tid):
                     failed.append(tid)
                     print(f"cannot unblock {tid} (not blocked/scheduled?)", file=sys.stderr)
                 else:
    -                print(f"Unblocked {tid}")
    +                print(f"Unblocked {tid}" + (f": {reason}" if reason else ""))
         return 0 if not failed else 1
     
     

  • scripts/release.py

    @@ -59,6 +59,7 @@
         "[redacted:email]": "wangpuv",
         "[email protected]": "ticketclosed-wontfix",
         "[redacted:email]": "victorGPT",
    +    "[email protected]": "julio-cloudvisor",
         # teknium (multiple emails)
         "[redacted:email]": "teknium1",
         "[redacted:email]": "kenyonxu",