{"repo":"NousResearch/hermes-agent","public_id":"37361","display_label":"Collapsing terminal sessions into shared containers","summary":"These issues and PRs concern a bug where Docker creates separate containers per terminal session, preventing shared auth state, and related fixes or features to collapse sessions with matching CWD or subagent task IDs into a shared container.","subsystem":"environments","counts":{"members":3,"open_issues":0,"open_issues_distinct":0,"open_prs":0,"closed_issues":1,"merged_prs":1,"attempt_prs":1},"landed_fix":{"status":"merged_to_main","basis":"structural","pr":41822,"merged_at":"2026-06-08T06:04:55+00:00"},"resolution":{"state":"resolved","by":"pr-41822"},"freshness":{"state":"verified","last_verified_at":"2026-06-08T06:04:55+00:00","is_stale":false},"grouping":{"backbone":"STRUCTURAL_SPANNING","link_density":0.6666666666666666},"fix_edges":[{"issue_number":37361,"pr_number":41822,"tier":"verified","basis":"closing_ref","confidence":0.95,"recoverable_from_timeline":true,"pr_merged_at":"2026-06-08T06:04:55+00:00"}],"members":[{"kind":"issue","number":37361,"title":"[Bug]: terminal.backend: docker creates a separate container per session — auth state cannot be shared across TUI, gateway, and dashboard","url":null,"state":"closed"},{"kind":"pr","number":37372,"title":"fix(terminal): collapse CWD-only overrides to shared container","url":null,"state":"closed","close_reason":{"refs":[{"kind":"pr","value":"#41822","number":41822}],"category":"merged_via","implication":"superseded"},"merged":false},{"kind":"pr","number":41822,"title":"fix(terminal): collapse CWD-only overrides to shared container","url":null,"state":"merged","close_reason":{"category":"merged"},"merged":true,"is_fix_pr":true,"fix_tier":"verified","files_changed":["tests/tools/test_shared_container_task_id.py","tools/terminal_tool.py"],"fix_hunks":[{"file":"tests/tools/test_shared_container_task_id.py","hunks":["@@ -105,3 +105,49 @@ def test_get_active_env_honours_rl_override():\n         terminal_tool.clear_task_env_overrides(\"rl-42\")\n         terminal_tool._active_environments.pop(\"default\", None)\n         terminal_tool._active_environments.pop(\"rl-42\", None)\n+\n+\n+def test_cwd_only_override_collapses_to_default():\n+    \"\"\"CWD-only overrides (ACP adapter workspace tracking) must NOT trigger\n+    container isolation — they should collapse to the shared 'default'\n+    container so all surfaces (TUI, gateway, dashboard) share one sandbox.\n+    Regression for #37361.\"\"\"\n+    terminal_tool.register_task_env_overrides(\n+        \"acp-session-abc\", {\"cwd\": \"/home/user/project\"}\n+    )\n+    try:\n+        assert (\n+            terminal_tool._resolve_container_task_id(\"acp-session-abc\")\n+            == \"default\"\n+        )\n+    finally:\n+        terminal_tool.clear_task_env_overrides(\"acp-session-abc\")\n+\n+\n+def test_cwd_plus_docker_image_keeps_own_id():\n+    \"\"\"When overrides include both cwd AND docker_image, isolation must\n+    still be honoured (RL/benchmark pattern with explicit cwd).\"\"\"\n+    terminal_tool.register_task_env_overrides(\n+        \"rl-with-cwd\", {\"docker_image\": \"myimg:latest\", \"cwd\": \"/workspace\"}\n+    )\n+    try:\n+        assert (\n+            terminal_tool._resolve_container_task_id(\"rl-with-cwd\")\n+            == \"rl-with-cwd\"\n+        )\n+    finally:\n+        terminal_tool.clear_task_env_overrides(\"rl-with-cwd\")\n+\n+\n+def test_env_type_override_keeps_own_id():\n+    \"\"\"env_type is an isolation key — must trigger per-task container.\"\"\"\n+    terminal_tool.register_task_env_overrides(\n+        \"bench-env\", {\"env_type\": \"sandbox\", \"cwd\": \"/work\"}\n+    )\n+    try:\n+        assert (\n+            terminal_tool._resolve_container_task_id(\"bench-env\")\n+            == \"bench-env\"\n+        )\n+    finally:\n+        terminal_tool.clear_task_env_overrides(\"bench-env\")"]},{"file":"tools/terminal_tool.py","hunks":["@@ -1006,9 +1006,20 @@ def _resolve_container_task_id(task_id: Optional[str]) -> str:\n     task_id, we honour it by returning the task_id unchanged -- those\n     rollouts need their own isolated sandbox, which is the whole point of\n     the override.\n+\n+    CWD-only overrides (registered by the ACP adapter for workspace\n+    tracking) are *not* isolation signals — they should not cause each\n+    session to spin up its own container.  Only overrides containing\n+    backend-specific image keys or ``env_type`` trigger isolation.\n     \"\"\"\n+    _ISOLATION_KEYS = frozenset({\n+        \"docker_image\", \"modal_image\", \"singularity_image\",\n+        \"daytona_image\", \"env_type\",\n+    })\n     if task_id and task_id in _task_env_overrides:\n-        return task_id\n+        overrides = _task_env_overrides[task_id]\n+        if set(overrides.keys()) & _ISOLATION_KEYS:\n+            return task_id\n     return \"default\"\n \n \n"]}]}],"trust":{"default_tier":"verified","includes_suggested":false}}