NousResearch/hermes-agent

read_file line counting bugs and fixes

Cluster 3907 · agent. Data as of 2026-10-27 11:58 UTC

5 open items. Fix merged in #107798 on 13 Sep 2026. Check it covers your case.

open issues

open PRs

items grouped

Known?: Yes. 13 related items grouped here, 3 issues already closed.
Fix event: A fix was merged to main in PR #107798. Check it covers your case. No release data is tracked.
Tracker: The maintainers' tracker marks this unresolved. That is separate from the fix event.
Still open: 0 issues and 5 PRs.

Next step: read #107798, then check it covers your case.

Read #107798 Pick up a Lab task

Multiple bug reports and fix attempts addressing two related read_file issues: undercounting total_lines for files without a trailing newline, and displaying a phantom empty last line for files that do end with a newline. One unrelated microphone device selector feature is also present.

Open issues0

No open issues.

Open PRs5

PR#3927fix(tools): read_file() undercounts total_lines for files without trailing newline
PR#20814fix(file_operations): correct total_lines for files without trailing newline
PR#22945fix(file): count unterminated final line in read_file
PR#42929fix(tools): count file lines newline-agnostically in read_file
PR#74372feat(desktop): add microphone device selector for voice mode

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

#107798 fix(tools): read_file counts unterminated final lines and stops rendering a phantom trailing line (salvage #106888, #49453)

merged to main

files: tests/tools/test_file_operations.py, tests/tools/test_file_operations_edge_cases.py, tests/tools/test_file_ops_single_roundtrip.py, tools/file_operations.py

4 PRs closed without merging

From the close comments: duplicate 2 · done elsewhere 1 · merged via another change 1

#3908 tools/file_operations: fix wc -l undercounting for files without trailing newline (#3907) · duplicate → #3908
#55696 fix(tools): read_file undercounts (and can drop) a final line without a trailing newline · done elsewhere → #107798, #106888, #49453
#55757 fix(file): count unterminated final line in read_file · duplicate → #42929, #55697, #55696, #22945
#106888 fix(tools): count final unterminated line in read_file total_lines · merged via another change → 6f62aff, #107798

Closed issues · 3

Closed#3907[Bug]: read_file() undercounts total_lines for files without trailing newline
Closed#55697read_file undercounts total_lines and can silently drop the last line of a file without a trailing newline
Closed#59999[Bug] read_file total_lines is inaccurate — uses wc -l which counts newlines, not lines

How this cluster was grouped

Link evidence (partly structural links): some members are connected by structural evidence (shared changed files, or a closing/superseded reference); the rest are joined by an automated relevance judgement over their text.
Members outside that structural core may belong to a different underlying problem.
Pairwise link density 0.15: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem: agent
Merged PRs: #107798
Closed issues: 3
Attempts: 4 PRs closed without merging
Fix link checked: 13 Sep 2026

For your agent

The same facts, typed.

cluster/3907.json
cluster/3907.md