Windows desktop app icon format fixes (.ico)
NousResearch/hermes-agent · cluster 41305 · apps/desktop
Data as of
Nothing open on GitHub. Fix merged in #50808. Check it covers your case.
The short answer
- Known?
- Yes. 6 related items grouped here, 2 issues already closed.
- Fix event
- A fix was merged to main in PR #50808. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
unresolved. That is separate from the fix event. - Still open
- Nothing open on GitHub.
A bug report and related fixes addressing Windows taskbar and notification icons that were missing or incorrect due to PNG files being used instead of the required .ico format.
Open issues0
Open PRs0
Fixes on record
-
#50808 fix(desktop): set AppUserModelID on Windows so notifications fire
files:
apps/desktop/electron/main.cjsShow the diff
-
apps/desktop/electron/main.cjs@@ -620,6 +620,16 @@ function previewFileMetadata(filePath, mimeType) { } app.setName(APP_NAME) +// Windows toast notifications silently no-op unless an AppUserModelID is set: +// `new Notification().show()` returns without error and nothing appears. The +// AUMID must match the installed Start Menu shortcut's AUMID, which +// electron-builder derives from the build `appId` (com.nousresearch.hermes) — +// keep this string in sync with package.json `build.appId`. macOS/Linux don't +// need this, so gate it on Windows. (Fixes: desktop approval/turn notifications +// never firing on Windows.) +if (IS_WINDOWS) { + app.setAppUserModelId('com.nousresearch.hermes') +} // Seed the native About panel with the live Hermes version. This is refreshed // on every open via the explicit "About" menu handler (refreshAboutPanel), so // an in-place `hermes update` mid-session is reflected without an app restart;
-
-
#75937 fix(desktop): make the Windows app icon match native icon size
files:
apps/desktop/assets/icon.ico,apps/desktop/electron/main.ts
2 PRs closed without merging
From the close comments: done elsewhere 2
Closed issues · 2
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.42: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab