Redaction masking lowercase variables; IGNORECASE removal and tests
Cluster 4367 · agent. Data as of
Nothing open on GitHub. Fix merged in #5185 on 5 Apr 2026. Check it covers your case.
The short answer
- Known?
- Yes. 4 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #5185. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #5185. That is separate from the fix event. - Still open
- Nothing open on GitHub.
The members concern redaction incorrectly masking lowercase Python variable assignments, with a bug report and related changes that remove re.IGNORECASE from _ENV_ASSIGN_RE and add regression tests. They appear to share one theme, though the titles alone don't confirm the outcome of any change.
Open issues0
Open PRs0
Fixes on record
-
#5185 test(redact): add regression tests for lowercase variable redaction (#4367)
files:
tests/agent/test_redact.pyShow the diff
-
tests/agent/test_redact.py@@ -82,6 +82,38 @@ def test_path_unchanged(self): result = redact_sensitive_text(text) assert result == text + def test_lowercase_python_variable_token_unchanged(self): + # Regression: #4367 — lowercase 'token' assignment must not be redacted + text = "before_tokens = [redacted:secret-assignment]" + result = redact_sensitive_text(text) + assert result == text + + def test_lowercase_python_variable_api_key_unchanged(self): + # Regression: #4367 — lowercase 'api_key' must not be redacted + text = "api_key = config.get('api_key')" + result = redact_sensitive_text(text) + assert result == text + + def test_typescript_await_token_unchanged(self): + # Regression: #4367 — 'await' keyword must not be redacted as a secret value + text = "const token = await getToken();" + result = redact_sensitive_text(text) + assert result == text + + def test_typescript_await_secret_unchanged(self): + # Regression: #4367 — similar pattern with 'secret' variable + text = "const secret = await fetchSecret();" + result = redact_sensitive_text(text) + assert result == text + + def test_export_whitespace_preserved(self): + # Regression: #4367 — whitespace before uppercase env var must be preserved + text = "export SECRET_TOKEN=mypassword" + result = redact_sensitive_text(text) + assert result.startswith("export ") + assert "SECRET_TOKEN=" in result + assert "mypassword" not in result + class TestJsonFields: def test_json_api_key(self):
-
2 PRs closed without merging
From the close comments: done elsewhere 2
Closed issues · 1
- Closed#4367[Bug]: Redaction incorrectly masks lowercase Python variable assignments
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.50: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Subsystem
- agent
- Merged PRs
- #5185
- Closed issues
- 1
- Attempts
- 2 PRs closed without merging
- Fix link checked
- 5 Apr 2026. This confirmation is old and may be out of date (a revert or reopen would not have invalidated it here); re-verify.