# NousResearch/hermes-agent · PTY session disposal on desktop quit/restart

## Open now

- Nothing open on GitHub.

These items concern a crash or race condition during application quit or update-restart caused by open PTY sessions not being disposed in the before-quit handler. Two are fixes and one is a bug report describing the underlying issue.

## TL;DR

- 3 member(s): 0 open issue(s), 1 closed issue(s), 0 open PR(s), 1 merged PR(s), 1 PR(s) closed without merging.
- A fix was merged to main in PR #48421. Verify it addresses your case.
- **Recommended:** read PR #48421 (and any competing PRs below) before filing. Confirm the merged change covers your symptom.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `resolved` · deciding PR(s): `pr-48421`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.67`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Closed / duplicate issues

- #48335: Desktop: SIGABRT crash on quit/update-restart — node-pty ThreadSafeFunction teardown race (ptys not disposed in before-quit)

## Prior & competing PRs

- **#48421: fix(desktop): dispose open PTY sessions in before-quit handler**. merged to main · fix tier `verified`
  - maintainer direction: category `merged`
  - files: `apps/desktop/electron/main.cjs`, `scripts/release.py`
  - fix hunks:
  - `apps/desktop/electron/main.cjs`

    ```diff
    @@ -6551,6 +6551,12 @@ app.on('before-quit', () => {
       flushDesktopLogBufferSync()
       closePreviewWatchers()
     
    +  // Kill open PTYs before environment teardown to avoid the node-pty#904
    +  // ThreadSafeFunction SIGABRT race.
    +  for (const id of [...terminalSessions.keys()]) {
    +    disposeTerminalSession(id)
    +  }
    +
       if (hermesProcess && !hermesProcess.killed) {
         hermesProcess.kill('SIGTERM')
       }
    ```
  - `scripts/release.py`

    ```diff
    @@ -45,6 +45,7 @@
     
     # Auto-extracted from noreply emails + manual overrides
     AUTHOR_MAP = {
    +    "286497132+srojk34@users.noreply.github.com": "srojk34",
         "59806492+sitkarev@users.noreply.github.com": "sitkarev",
         "[redacted:email]": "omegazheng",
         "220877172+james47kjv@users.noreply.github.com": "james47kjv",
    ```
- **#48393: fix(desktop): dispose open PTY sessions in before-quit handler**. closed without merge
  - maintainer direction: category `merged_via`; implication `superseded`; refs `#48421`, `#904`, `#48335`

## Fix status

- Merged to main in PR #48421 (cited above). No release data is tracked. Verify downstream.
- Fix last verified (merged) `2026-06-18`.