NousResearch/hermes-agent

ACP tool call completion updates missing or not emitted

Cluster 50723 · acp. Data as of

1 open item. Fix merged in #114914 on 18 Sep 2026. Check it covers your case.

The short answer

1open issue
0open PRs
4items grouped
Known?
Yes. 4 related items grouped here, 0 issues already closed.
Fix event
A fix was merged to main in PR #114914. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this unresolved. That is separate from the fix event.
Still open
1 issue and 0 PRs.

The members share a theme around ACP tool calls: one bug report says tool completions can be missing, and three pull requests propose emitting tool completion updates (via a progress callback) or ensuring every tool call reaches a terminal status before a turn ends. The titles alone do not show whether any of these changes were merged or fixed the problem.

Open issues1

  • Issue#50723[Bug]: ACP tool completions can be missing

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #114914 fix(acp): every tool call reaches a terminal status before the turn ends (#114395, salvage #114442)

    merged to main

    files: acp_adapter/edit_approval.py, acp_adapter/events.py, acp_adapter/permissions.py, acp_adapter/server.py, acp_adapter/tools.py, contributors/emails/[redacted:email], tests/acp_adapter/test_events.py, tests/acp_adapter/test_permissions.py, tests/acp_adapter/test_server.py, website/docs/developer-guide/acp-internals.md

2 PRs closed without merging

From the close comments: duplicate 1 · superseded by another PR 1

  • #50741 fix(acp): emit tool.completed updates immediately via progress callback (#50723) · superseded by another PR → 58e38f4, #114914, #114395, #114442
  • #50742 fix(acp): emit tool completion updates from progress callback (#50723) · duplicate → #50741, #50723
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.50: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
acp
Merged PRs
#114914
Closed issues
0
Attempts
2 PRs closed without merging
Fix link checked
18 Sep 2026

For your agent

The same facts, typed.