Linux/WSL desktop window controls missing or broken

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #53989 fix(desktop): restore window controls on plain Linux (min/max/close)

  merged to main

  files: apps/desktop/electron/main.cjs, apps/desktop/electron/titlebar-overlay-width.cjs, apps/desktop/electron/titlebar-overlay-width.test.cjs, scripts/release.py

  Show the diff

  • apps/desktop/electron/main.cjs

    @@ -534,9 +534,10 @@ function getTitleBarOverlayOptions() {
         return { height: TITLEBAR_HEIGHT }
       }
     
    -  // Windows + WSLg paint WCO natively; plain Linux disables it (frameless hidden
    -  // titlebar still applies).
    -  if (!IS_WINDOWS && !IS_WSL) {
    +  // WSLg paints WCO via the RDP host's own min/max/close, so requesting
    +  // an Electron overlay there just leaves a dead gap. Plain Linux (KDE,
    +  // GNOME) can use the native overlay — let it through.
    +  if (!IS_WINDOWS && IS_WSL) {
         return false
       }
     
    @@ -3788,7 +3789,7 @@ function getWindowButtonPosition() {
     }
     
     function getNativeOverlayWidth() {
    -  return computeNativeOverlayWidth({ isWindows: IS_WINDOWS, isWsl: IS_WSL })
    +  return computeNativeOverlayWidth({ isWindows: IS_WINDOWS, isWsl: IS_WSL, isMac: IS_MAC })
     }
     
     function getWindowState() {

  • apps/desktop/electron/titlebar-overlay-width.cjs

    @@ -1,11 +1,24 @@
    -// Pre-layout fallback for WCO right-edge reservation (--titlebar-tools-right).
    -// Live width comes from navigator.windowControlsOverlay in the renderer.
    +'use strict'
     
     const OVERLAY_FALLBACK_WIDTH = 144
     
    -/** @param {{ isWindows?: boolean, isWsl?: boolean }} opts */
    -function nativeOverlayWidth({ isWindows = false, isWsl = false } = {}) {
    -  return isWindows || isWsl ? OVERLAY_FALLBACK_WIDTH : 0
    +/**
    + * Static pre-layout reservation (px) for the right-side native window-controls
    + * overlay (min/max/close). Only a FALLBACK — once laid out the renderer reads
    + * the exact width from navigator.windowControlsOverlay
    + * (use-window-controls-overlay-width.ts) and uses this value only when the WCO
    + * API is unavailable.
    + *
    + * macOS uses traffic lights positioned via trafficLightPosition, not a WCO
    + * overlay, so it reserves nothing here. Every other desktop platform now paints
    + * the Electron overlay (Windows, WSLg, and plain Linux KDE/GNOME), so they all
    + * reserve the fallback width.
    + *
    + * @param {{ isWindows?: boolean, isWsl?: boolean, isMac?: boolean }} opts
    + */
    +function nativeOverlayWidth({ isWindows = false, isWsl = false, isMac = false } = {}) {
    +  if (isMac) return 0
    +  return OVERLAY_FALLBACK_WIDTH
     }
     
     module.exports = { OVERLAY_FALLBACK_WIDTH, nativeOverlayWidth }

  • apps/desktop/electron/titlebar-overlay-width.test.cjs

    @@ -18,10 +18,17 @@ test('WSLg paints the same WCO, so it reserves the same fallback width', () => {
       assert.equal(nativeOverlayWidth({ isWsl: true }), OVERLAY_FALLBACK_WIDTH)
     })
     
    -test('plain Linux and macOS reserve nothing', () => {
    -  assert.equal(nativeOverlayWidth({ isWindows: false, isWsl: false }), 0)
    -  assert.equal(nativeOverlayWidth(), 0)
    -  assert.equal(nativeOverlayWidth({}), 0)
    +test('plain Linux paints the WCO too, so it reserves the fallback width', () => {
    +  // Regression #53185: re-enabling the overlay on plain Linux (KDE/GNOME)
    +  // without reserving its width left the native min/max/close buttons painting
    +  // on top of the app's right-edge titlebar tools.
    +  assert.equal(nativeOverlayWidth({ isWindows: false, isWsl: false }), OVERLAY_FALLBACK_WIDTH)
    +  assert.equal(nativeOverlayWidth(), OVERLAY_FALLBACK_WIDTH)
    +  assert.equal(nativeOverlayWidth({}), OVERLAY_FALLBACK_WIDTH)
    +})
    +
    +test('macOS uses traffic lights, not a WCO overlay, so it reserves nothing', () => {
    +  assert.equal(nativeOverlayWidth({ isMac: true }), 0)
     })
     
     test('the fallback width is a sane positive pixel value', () => {

  • scripts/release.py

    @@ -70,6 +70,7 @@
         "[redacted:email]": "uperLu",  # PR #50958 salvage (rename plugins/cron → plugins/cron_providers; #50872)
         "[redacted:email]": "yusekiotacode",  # PR #48706 salvage (anthropic OAuth login token endpoint → platform.claude.com; #45250/#49821)
         "[redacted:email]": "s010mn",  # PR #29221 salvage (ollama-cloud reasoning_effort xhigh→max)
    +    "[redacted:email]": "chriswesley4",  # PR #53185 salvage (re-enable titleBarOverlay on plain Linux; missing min/max/close regression)
         "[redacted:email]": "jeeves-assistant",  # PR #50771 (computer-use CuaDriver vision capture routing)
         "[redacted:email]": "ScotterMonk",  # PR #50145 salvage (cron output truncation: adapter-aware chunking, #50126)
         "[redacted:email]": "TutkuEroglu",  # PR #50481 salvage (AGENTS.md stale token-lock adapter path)

• #113247 fix(desktop): working WSLg window controls and native Wayland launch

  merged to main

  files: apps/desktop/electron/entry.ts, apps/desktop/electron/main.ts, apps/desktop/electron/preload.ts, apps/desktop/electron/titlebar-overlay-width.test.ts, apps/desktop/electron/titlebar-overlay-width.ts, apps/desktop/electron/window-chrome-events.test.ts, apps/desktop/electron/window-chrome-events.ts, apps/desktop/electron/window-controls.test.ts, apps/desktop/electron/window-controls.ts, apps/desktop/electron/wslg-launch-process.test.ts, apps/desktop/electron/wslg-launch-process.ts, apps/desktop/electron/wslg-launch.test.ts, apps/desktop/electron/wslg-launch.ts, apps/desktop/scripts/bundle-electron-main.mjs, apps/desktop/src/app/contrib/wiring.tsx, apps/desktop/src/app/shell/wslg-window-controls.test.tsx, apps/desktop/src/app/shell/wslg-window-controls.tsx, apps/desktop/src/global.d.ts, website/docs/user-guide/desktop.md