# NousResearch/hermes-agent · Strip ASCII control characters from saved API keys

## Open now

- 1 issue, 2 PRs open on GitHub.
- #55335: save_env_value can persist ASCII control characters in API keys
- PR #55336: fix(config): strip control chars from saved env credentials
- PR #55767: fix(cli): strip ASCII control characters in save_env_value

These members center on save_env_value potentially persisting ASCII control characters in API keys or credentials, with one issue report and several pull requests proposing to strip such characters before saving. The titles do not indicate whether any of these changes have been merged or verified.

## TL;DR

- 5 member(s): 1 open issue(s), 0 closed issue(s), 2 open PR(s), 0 merged PR(s), 2 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.40`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #55335: save_env_value can persist ASCII control characters in API keys

## Prior & competing PRs

- **#55406: fix: strip ASCII control characters from API keys before saving (#55335)**. closed without merge · fix tier `suggested`
  - maintainer direction: category `superseded_by_pr`; implication `superseded`
  - _suggested-tier fix detail withheld; re-request with `?tier=all` to include it._
- **#55336: fix(config): strip control chars from saved env credentials**. open
  - maintainer direction: category `uncategorized`; implication `needs_llm`
  - files: `hermes_cli/config.py`, `hermes_cli/onepassword_secrets_cli.py`, `hermes_cli/secrets_cli.py`, `tests/hermes_cli/test_config.py`
- **#55767: fix(cli): strip ASCII control characters in save_env_value**. open
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#55336`
  - files: `hermes_cli/config.py`, `tests/hermes_cli/test_config.py`
- **#58074: fix(config): strip control chars from saved credentials**. closed without merge
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#55336`

## Fix status

- No merged fix on record.
- Subsystem: `hermes_cli`