# NousResearch/hermes-agent · ACP sensitive-path guard symlink resolution fix

## Open now

- 1 issue, 2 PRs open on GitHub.
- #55367: ACP auto-approve sensitive-path guard ignores symlinks, so an innocuously named link to a credential file is approved without prompting
- PR #57458: fix(acp): symlink-resolve sensitive-path guard (#55367)
- PR #58628: fix(acp): resolve symlinks in sensitive-path auto-approve guard (#55367)

These members address a security gap where the ACP auto-approve sensitive-path guard did not resolve symlinks, allowing a symlink with an innocuous name pointing to a credential file to bypass prompting. The group covers the bug report and associated fix.

## TL;DR

- 4 member(s): 1 open issue(s), 0 closed issue(s), 2 open PR(s), 0 merged PR(s), 1 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.50`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #55367: ACP auto-approve sensitive-path guard ignores symlinks, so an innocuously named link to a credential file is approved without prompting

## Prior & competing PRs

- **#55368: Resolve symlinks in the ACP auto-approve sensitive-path guard**. closed without merge
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#41351`
- **#57458: fix(acp): symlink-resolve sensitive-path guard (#55367)**. open
  - maintainer direction: category `uncategorized`; implication `needs_llm`; refs `060779bb762a68524e13758b1b8cd08129417803`
  - files: `acp_adapter/edit_approval.py`, `tests/acp/test_edit_approval.py`
- **#58628: fix(acp): resolve symlinks in sensitive-path auto-approve guard (#55367)**. open
  - maintainer direction: category `duplicate_of`; implication `duplicate`; refs `#41351`, `#55367`, `#55368`, `#57458`
  - files: `acp_adapter/edit_approval.py`

## Fix status

- No merged fix on record.
- Subsystem: `acp`
