Matrix typing indicator lingering after response is sent

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

• #10239 fix(gateway): fix matrix lingering typing indicator

  merged to main

  files: gateway/platforms/matrix.py, tests/gateway/test_matrix.py

  Show the diff

  • gateway/platforms/matrix.py

    @@ -729,6 +729,14 @@ async def send_typing(
                 except Exception:
                     pass
     
    +    async def stop_typing(self, chat_id: str) -> None:
    +        """Stop the Matrix typing indicator."""
    +        if self._client:
    +            try:
    +                await self._client.set_typing(RoomID(chat_id), timeout=0)
    +            except Exception:
    +                pass
    +
         async def edit_message(
             self, chat_id: str, message_id: str, content: str
         ) -> SendResult:

  • tests/gateway/test_matrix.py

    @@ -335,6 +335,29 @@ def _make_adapter():
         return adapter
     
     
    +# ---------------------------------------------------------------------------
    +# Typing indicator
    +# ---------------------------------------------------------------------------
    +
    +class TestMatrixTypingIndicator:
    +    def setup_method(self):
    +        self.adapter = _make_adapter()
    +        self.adapter._client = MagicMock()
    +        self.adapter._client.set_typing = AsyncMock()
    +
    +    @pytest.mark.asyncio
    +    async def test_stop_typing_clears_matrix_typing_state(self):
    +        """stop_typing() should send typing=false instead of waiting for timeout expiry."""
    +        from gateway.platforms.matrix import RoomID
    +
    +        await self.adapter.stop_typing("!room:example.org")
    +
    +        self.adapter._client.set_typing.assert_awaited_once_with(
    +            RoomID("!room:example.org"),
    +            timeout=0,
    +        )
    +
    +
     # ---------------------------------------------------------------------------
     # mxc:// URL conversion
     # ---------------------------------------------------------------------------
    @@ -1831,4 +1854,3 @@ async def test_set_presence_no_client(self):
             assert result is False
     
     
    -