Windows probe subprocess pipe deadlock fixes
NousResearch/hermes-agent · cluster 66037 · apps/desktop
Data as of
Nothing open on GitHub. Fix merged in #67999. Check it covers your case.
The short answer
- Known?
- Yes. 9 related items grouped here, 3 issues already closed.
- Fix event
- A fix was merged to main in PR #67999. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
partially resolved, deciding PR #67999. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and fixes address a Windows-specific deadlock where child or orphaned processes inherit capture pipes from git/env probes, causing reads to hang indefinitely and blocking agent initialization or session creation. Multiple fixes apply timeouts and alternate I/O strategies to bound post-kill cleanup.
Open issues0
Open PRs0
Fixes on record
-
#67999 fix(env-probe): stuck Windows probe can no longer deadlock system-prompt builds
files:
tests/tools/test_env_probe.py,tools/env_probe.py -
#68045 fix(env-probe): capture probe output via temp files so descendants can't stall the read (#67964 follow-up)
files:
tests/tools/test_env_probe.py,tools/env_probe.py -
#68997 fix(windows): share one bounded, tree-killing git probe across both probe call sites
files:
agent/coding_context.py,hermes_cli/_subprocess_compat.py,tests/test_windows_subprocess_no_window_flags.py,tui_gateway/git_probe.py
3 PRs closed without merging
From the close comments: superseded by another PR 2 · merged via another change 1
-
#67991 fix(tools): bound env probe subprocess so a Windows inherited pipe can't wedge sessions (#67964) · merged via another change →
e77ffdc,#68045,#67999,#67964 -
#68622 fix(gateway): bound the post-kill cleanup in the Windows git probe · superseded by another PR →
#68997,#66038,#66037 -
#68629 fix(tui): bound post-kill cleanup in Windows git probe to prevent agent init timeout · superseded by another PR →
#68622
Closed issues · 3
- Closed#66037Windows: agent turn hangs forever in the git workspace probe when the 2.5s timeout fires (post-kill communicate deadlock)
- Closed#67964[Bug]: Windows env probe can deadlock all new sessions when an orphaned pip child keeps capture pipes open
- Closed#68609[Bug]: Windows Desktop agent initialization times out after git probe leaves suspended child
How this cluster was grouped
-
Link evidence (
partly structural links): some members are connected by structural evidence (shared changed files, or a closing/superseded reference); the rest are joined by an automated relevance judgement over their text. - Members outside that structural core may belong to a different underlying problem.
-
Pairwise link density
0.19: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab