AIAgent.close leaks Codex subprocess session
NousResearch/hermes-agent · cluster 66671 · agent
Data as of
Nothing open on GitHub. Fix merged in #115778. Check it covers your case.
The short answer
- Known?
- Yes. 6 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #115778. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #115778. That is separate from the fix event. - Still open
- Nothing open on GitHub.
A bug was reported and multiple fixes proposed to ensure AIAgent.close() properly closes the _codex_session, preventing Codex app-server subprocess leaks.
Open issues0
Open PRs0
Fixes on record
-
#115778 fix(agent): evicted Codex-route agents no longer leak their app-server child on soft release (#72548, #66671)
files:
hermes_cli/cli_agent_setup_mixin.py,hermes_cli/cli_chat_turn_mixin.py,hermes_cli/cli_commands_mixin.py,hermes_cli/cli_model_switch_mixin.py,run_agent.py,tests/agent/test_codex_app_server_lifecycle.py,tests/hermes_cli/test_cli_retire_agent.py -
#121345 test: native provider E2E suites: Bedrock Converse, Gemini, Vertex, Codex app-server and Copilot ACP wire contracts proven against validating fakes
files:
tests/e2e/core/providers/__init__.py,tests/e2e/core/providers/_native_helpers.py,tests/e2e/core/providers/test_native_bedrock_converse_faults.py,tests/e2e/core/providers/test_native_bedrock_converse_turns.py,tests/e2e/core/providers/test_native_codex_app_server.py,tests/e2e/core/providers/test_native_codex_app_server_faults.py,tests/e2e/core/providers/test_native_copilot_acp.py,tests/e2e/core/providers/test_native_copilot_acp_errors.py,tests/e2e/core/providers/test_native_copilot_acp_streaming.py,tests/e2e/core/providers/test_native_gemini_compaction.py,tests/e2e/core/providers/test_native_gemini_errors.py,tests/e2e/core/providers/test_native_gemini_schema.py,tests/e2e/core/providers/test_native_gemini_tools.py,tests/e2e/core/providers/test_native_vertex_errors.py,tests/e2e/core/providers/test_native_vertex_recovery.py,tests/e2e/core/providers/test_native_vertex_tools.py,tests/fakes/providers/__init__.py,tests/fakes/providers/bedrock_converse.py,tests/fakes/providers/codex_app_server.py,tests/fakes/providers/copilot_acp.py(+2 more)
3 PRs closed without merging
From the close comments: duplicate 1 · stale or abandoned 1 · other 1
- #66678 fix(agent): close _codex_session in AIAgent.close() to prevent subprocess leaks (#66671) · other
-
#66865 fix(agent): close _codex_session in AIAgent.close() to prevent Codex subprocess leak (#66671) · duplicate →
#66678 -
#66904 fix(agent): close Codex app-server subprocess on AIAgent.close() (#66671) · stale or abandoned →
#66678,#55450
Closed issues · 1
- Closed#66671[Bug]: session.close leaks the Codex app-server process tree — AIAgent.close never closes _codex_session
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.33: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab