GlyphSpinner performance: reduce React and style recalcs
NousResearch/hermes-agent · cluster 72844 · apps/desktop
Data as of
Nothing open on GitHub. Fix merged in #78266. Check it covers your case.
The short answer
- Known?
- Yes. 7 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #78266. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #91473. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and PRs focus on GlyphSpinner causing excessive React commits and document-scale style recalculations in Desktop sessions. The work explores moving spinner animation off React and onto the compositor to reduce rendering overhead.
Open issues0
Open PRs0
Fixes on record
-
#78266 perf(desktop): keep GlyphSpinner frames out of React commits (#74357 salvage)
files:
apps/desktop/src/components/ui/glyph-spinner.test.tsx,apps/desktop/src/components/ui/glyph-spinner.tsx -
#91473 perf(desktop): spinners animate on the compositor — no more document-scale recalcs (salvage #89869)
files:
apps/desktop/e2e/glyph-spinner.spec.ts,apps/desktop/scripts/run-short-session-hang-repro.mjs,apps/desktop/src/app/chat/chat-swap-overlay.test.tsx,apps/desktop/src/app/chat/chat-swap-overlay.tsx,apps/desktop/src/components/assistant-ui/thread/assistant-message.tsx,apps/desktop/src/components/assistant-ui/thread/inter-agent-collapse.test.tsx,apps/desktop/src/components/assistant-ui/thread/preview-embeds.test.tsx,apps/desktop/src/components/assistant-ui/thread/status-invalidation-scope.test.tsx,apps/desktop/src/components/ui/glyph-spinner.css,apps/desktop/src/components/ui/glyph-spinner.test.tsx,apps/desktop/src/components/ui/glyph-spinner.tsx,apps/desktop/src/styles.css
4 PRs closed without merging
From the close comments: superseded by another PR 2 · merged via another change 1 · other 1
-
#73033 fix(desktop): stop GlyphSpinner React churn · other →
#74357 -
#74357 perf(desktop): keep GlyphSpinner frames out of React commits · superseded by another PR →
#73033,#78266 -
#89805 perf(desktop): eliminate GlyphSpinner-driven document-scale style recalcs · superseded by another PR →
#89869 -
#89869 perf(desktop): eliminate GlyphSpinner-driven document-scale style recalcs · merged via another change →
#91473
Closed issues · 1
- Closed#72844[Bug]: GlyphSpinner causes ~12.6 React commits/s in busy-but-silent Desktop sessions
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.43: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab