NousResearch/hermes-agent
Background-review read-mark thread-safety bug and fixes
Cluster 75618 · agent. Data as of
Nothing open on GitHub. Fix merged in #94511. Check it covers your case.
The short answer
0open issues
0open PRs
5items grouped
- Known?
- Yes. 5 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #94511. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #94511. That is separate from the fix event. - Still open
- Nothing open on GitHub.
A bug where background-review read marks stored in a ContextVar are lost across per-call thread dispatch, plus two fix attempts replacing or scoping that storage with a thread-safe alternative.
Open issues0
Open PRs0
Fixes on record
-
#94511 fix(skills): background-review curator patches no longer refused after skill_view (#75618, salvage #73975)
files:
tests/tools/test_skill_manager_tool.py,tools/skill_manager_tool.py
3 PRs closed without merging
From the close comments: merged via another change 3
-
#73975 fix(skills): preserve review read marks across tool contexts · merged via another change →
335c60e,#94511,#75618 -
#75661 fix(skills): scope background-review read marks per review fork · merged via another change →
335c60e,#94511,#73975 -
#83321 fix(skills): replace ContextVar with thread-safe set for background review marks · merged via another change →
335c60e,#75618,#94511,#73975
Closed issues · 1
- Closed#75618skill_manage always refuses background-review patches: ContextVar read-mark doesn't survive per-call thread dispatch
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Subsystem
- agent
- Merged PRs
- #94511
- Closed issues
- 1
- Attempts
- 3 PRs closed without merging
- Fix link checked
- 25 Aug 2026