NousResearch/hermes-agent

Scoping ACP approval callbacks away from global state

Cluster 8081 · acp adapter/bootstrap. Data as of

Nothing open on GitHub. Fix attempted, not merged.

The short answer

0open issues
0open PRs
3items grouped
Known?
Yes. 3 related items grouped here, 1 issue already closed.
Fix event
No fix has been merged to main. 1 PR closed without merging; see the attempts below.
Tracker
The maintainers' tracker marks this unresolved. That is separate from the fix event.
Still open
Nothing open on GitHub.

These items address how ACP approval callbacks are stored and invoked, moving from a global or swapped terminal state toward per-task or per-session scoped registries. The work involves wiring up the callback mechanism and making it thread-local or session-local.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #13525 fix(acp): wire approval callback + make callbacks thread-local

    merged to mainSuggested link · files and diff not shown

1 PR closed without merging

From the close comments: done elsewhere 1

  • #9157 fix(acp): replace global approval callback with task-scoped registry · done elsewhere → 62348cf, #13525
Closed issues · 1
  • Closed#8081Scope ACP approval callbacks per session instead of swapping global terminal state
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
acp adapter/bootstrap
Merged PRs
#13525
Closed issues
1
Attempts
1 PR closed without merging

For your agent

The same facts, typed.