Cairn
NousResearch/hermes-agent

ACP reasoning_config handling fixes

Cluster 85153 · acp. Data as of

Nothing open on GitHub. Fix merged in #115765. Check it covers your case.

The short answer

0open issues
0open PRs
5items grouped
Known?
Yes. 5 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #115765. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #115765. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and pull requests address bugs in how ACP resolves or applies reasoning_config, including cases where thinking text is lost or reasoning_effort settings are ignored for certain model types.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #115765 fix(codex): reasoning_effort none is sent on OpenAI Responses, gpt-4o/4.1 no longer 400 on openai-api, ACP honors reasoning config (#75227, #76255, #85153, salvage #85164)

    merged to main

    files: acp_adapter/session.py, agent/auxiliary_client.py, agent/curator.py, agent/model_metadata.py, agent/transports/codex.py, contributors/emails/[redacted:email], gateway/slash_commands_session.py, plugins/platforms/feishu/feishu_comment.py, tests/acp_adapter/test_session_reasoning_config.py, tests/agent/test_auxiliary_client.py, tests/agent/test_curator.py, tests/agent/test_error_classifier.py, tests/agent/transports/test_codex_transport.py, tests/gateway/test_compress_command.py, tests/gateway/test_feishu_comment.py, website/docs/user-guide/configuration.md

3 PRs closed without merging

From the close comments: superseded by another PR 2 · merged via another change 1

  • #85164 fix(acp): resolve reasoning_config for ACP and oneshot agents (#85153) · merged via another change → 80009fb, #115765, #75227, #76255, #85153, #85164
  • #89496 fix(acp): resolve reasoning_config so thinking text isn't lost · superseded by another PR → #100713
  • #100713 fix(agent): resolve reasoning_config at the init chokepoint, not per call site · superseded by another PR → #116513
Closed issues · 1
  • Closed#85153[Bug]: ACP ignores reasoning_effort: none for non-reasoning models
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
acp
Merged PRs
#115765
Closed issues
1
Attempts
3 PRs closed without merging
Fix link checked
19 Sep 2026

For your agent

The same facts, typed.

cluster/85153.json
cluster/85153.md