# NousResearch/hermes-agent · Approval prompt prediction and class-key bug fixes

## Open now

- 1 issue, 1 PR open on GitHub.
- #90136: bug: approvals test ignores approved dangerous-pattern class keys
- PR #104533: fix(approvals): predict prompts the way the runtime decides them (#90136, salvage #90138)

These items address bugs in the approvals system, specifically around correctly predicting prompts as the runtime would, honoring class-key approvals during dry-run, and fixing a test that incorrectly ignored dangerous-pattern class key approvals.

## TL;DR

- 3 member(s): 1 open issue(s), 0 closed issue(s), 1 open PR(s), 0 merged PR(s), 1 PR(s) closed without merging.
- No fix has been merged to main; one or more PRs were attempted (see below).
- **Recommended:** review the prior/competing PR(s) below. A fix was attempted but not merged; your case may extend or revive that work.

## Maintainer resolution verdict

- Internal-tracker verdict over this cluster's issue members: `unresolved`. This is distinct from the fix status above. Weigh it yourself.

## How this cluster was grouped

- Link evidence (`STRUCTURAL_SPANNING`): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
- Pairwise link density `0.67`: the share of member pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. `1.00` means every pair is linked.

## Open related issues

- #90136: bug: approvals test ignores approved dangerous-pattern class keys

## Prior & competing PRs

- **#90138: fix(approvals): honor class-key approvals in dry-run**. closed without merge
  - maintainer direction: category `superseded_by_pr`; implication `superseded`; refs `#104533`, `#90136`
- **#104533: fix(approvals): predict prompts the way the runtime decides them (#90136, salvage #90138)**. open
  - maintainer direction: category `uncategorized`; implication `needs_llm`; refs `34e779dac123369e3c88bd86da90f06a4c1acae0`, `693641aa8b4359c602283bdbbc14041e03bc47bc`, `7c9ca9791`
  - files: `hermes_cli/approvals_test.py`, `tests/hermes_cli/test_approvals_test.py`

## Fix status

- No merged fix on record.
- Subsystem: `hermes_cli`