Update stash restore safety and git state accuracy
NousResearch/hermes-agent · cluster 94264
Data as of
Nothing open on GitHub. Fix merged in #99555. Check it covers your case.
The short answer
- Known?
- Yes. 7 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #99555. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #99555. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and pull requests concern the update process incorrectly restoring invalid local Python from stash while reporting success, and separately misreporting git state during updates (false divergence, updates during rebase, incorrect completion status). Fixes focus on rejecting unsafe or unproven stash restores and ensuring honest git state reporting.
Open issues0
Open PRs0
Fixes on record
-
#99555 fix(update): reject stash restores that re-apply invalid Python (salvage #94287)
files:
hermes_cli/update_cmd.py,tests/hermes_cli/test_update_autostash.py,tests/hermes_cli/test_update_import_guard.py -
#126166 hermes update tells the truth about git state: no false divergence, no update under a rebase, no 'complete' with a parked patch, works from a PM venv
files:
hermes_cli/_early_recovery.py,hermes_cli/update_cmd.py,hermes_cli/update_cmd_stash.py,hermes_cli/update_owning_install.py,tests/e2e/core/upgrade/git/test_foreign_state.py,tests/e2e/core/upgrade/git/test_local_modifications.py,tests/e2e/core/upgrade/git/test_truthful_outcome.py,tests/e2e/core/upgrade/pm/test_stamps_and_doctor.py,tests/hermes_cli/test_update_autostash.py,tests/hermes_cli/test_update_diverged_rescue_ref.py,tests/hermes_cli/test_update_owning_install.py,tests/hermes_cli/test_update_parked_branch_guard.py
4 PRs closed without merging
From the close comments: done elsewhere 3 · superseded by another PR 1
-
#94287 fix(update): reject unsafe stash restores · done elsewhere →
#99555 -
#94303 fix(update): reject stash restores that re-apply invalid Python · superseded by another PR →
#94287 -
#94344 fix(update): fail closed on unproven stash restore · done elsewhere →
ca12cbd,#94264,#94344,#94287,#94303 -
#122828 fix(update): name this run's unsettled autostash before any update outcome · done elsewhere →
#126166
Closed issues · 1
- Closed#94264Update can restore invalid local Python and report success while every agent turn fails
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.29: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the Lab