NousResearch/hermes-agent

Locale-sensitive number formatting breaks tests

Cluster 98849. Data as of

Nothing open on GitHub. Fix merged in #120267 on 23 Sep 2026. Check it covers your case.

The short answer

0open issues
0open PRs
3items grouped
Known?
Yes. 3 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #120267. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #120267. That is separate from the fix event.
Still open
Nothing open on GitHub.

These items address vitest/desktop test failures caused by locale-dependent number and currency formatting when the system locale is not en-US. The work involves either pinning 'en-US' explicitly in formatting calls or adjusting test assertions to tolerate host locales.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #120267 test(desktop): respect host locales in UI assertions

    merged to main

    files: apps/desktop/src/app/session/hooks/use-prompt-actions/utils.test.ts, apps/desktop/src/app/settings/billing/index.test.tsx, apps/desktop/src/components/assistant-ui/thread/timestamp.test.ts, apps/desktop/src/components/assistant-ui/tool/fallback-model.test.ts

1 PR closed without merging

From the close comments: superseded by another PR 1

  • #98850 fix(desktop): pin 'en-US' in number/currency formatting so tests pass under non-en-US locales · superseded by another PR
Closed issues · 1
  • Closed#98849vitest suite fails under non-en-US system locale (bare `.toLocaleString()` / `Intl.NumberFormat(undefined, ...)`)
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#120267
Closed issues
1
Attempts
1 PR closed without merging
Fix link checked
23 Sep 2026

For your agent

The same facts, typed.